Open
Conversation
AbhirupaGhosh
changed the title
jananiravi
reviewed
Apr 3, 2026
Member
jananiravi
left a comment
jananiravi
left a comment
There was a problem hiding this comment.
Again, looks good to me, but need local runners: @epbrenner @eboyer221. Thanks!
| # nmcc <- (mcc + 1) / 2 | ||
|
|
||
| return(round(nmcc, 2)) | ||
| return(mcc) |
Member
There was a problem hiding this comment.
might still need to round to two decimals, right?
| "Calculation of log2(AUPRC/prior) may be inappropriate.")) | ||
| if (prior > 0.3 && prior < 0.7) { | ||
| warning(paste( | ||
| "Classes are roughly balanced.", |
| )) | ||
| } else if (prior >= 0.7) { | ||
| warning(paste( | ||
| "Classes are imbalanced toward the resistant phenotype.", |
Member
There was a problem hiding this comment.
toward = clarify more explicitly whether R/S is higher
|
|
||
| ```{r plot-prc} | ||
| test_data_plus_predictions <- readr::read_tsv(results/ML_pred/Sfl_drug_AMP_domains_binary_prediction.tsv) | ||
| test_data_plus_predictions <- readr::read_tsv(results / ML_pred / Sfl_drug_AMP_domains_binary_prediction.tsv) |
Member
There was a problem hiding this comment.
there is no " to define path and / is now ' / '. Will this even work? 🤔
|
|
||
| ```{r plot-roc} | ||
| test_data_plus_predictions <- readr::read_tsv(results/ML_pred/Sfl_drug_AMP_domains_binary_prediction.tsv) | ||
| test_data_plus_predictions <- readr::read_tsv(results / ML_pred / Sfl_drug_AMP_domains_binary_prediction.tsv) |
Member
There was a problem hiding this comment.
check this and topfeat below too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some necessary updates
Description
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.