ARM64 test workarounds #1939
Merged
ARM64 test workarounds #1939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slozier
approved these changes
Apr 7, 2025
Contributor
slozier
left a comment
slozier
left a comment
There was a problem hiding this comment.
Hmm, there are new Mono releases? Google doesn't know about Mono 6.20. 😄 I did find a 6.14 which I assume is what you meant.
Member
Author
Yep, that's the one… I think I was dreaming about 6.20 😄 No binaries though, it's a DIY kit, so I haven't tested in on Linux/ARM64 yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent release of Mono — 6.20.0 — sports native support for ARM64 on macOS. Unfortunately, it appears that conversions to floating point numbers can be one LSB off from what is happening on x86_64. This causes some of the tests to fail. This PR contains a couple of workarounds so that the overall test tun on ARM64/macOS passes.