Fixed "PersistentDataPath" usage in Editor context#2624
Merged
KABoissonneault merged 1 commit intoInterkarma:masterfrom Mar 29, 2024
Merged
Fixed "PersistentDataPath" usage in Editor context#2624KABoissonneault merged 1 commit intoInterkarma:masterfrom
KABoissonneault merged 1 commit intoInterkarma:masterfrom
Conversation
petchema
approved these changes
Mar 23, 2024
ajrb
approved these changes
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue caused by #2607.
Before #2607, PersistentDataPath was lazily initialized whenever it was requested. In #2607, I made it get defined on application start. I failed to consider that PersistentDataPath was used in Editor code. Currently, if you open the editor on the latest code, it should throw a null reference exception.
This change turns it back into lazy initialization, so editor code still initializes it.