Allow faction ruler type to be set by mods#2622
Merged
KABoissonneault merged 1 commit intoInterkarma:masterfrom Mar 23, 2024
Merged
Allow faction ruler type to be set by mods#2622KABoissonneault merged 1 commit intoInterkarma:masterfrom
KABoissonneault merged 1 commit intoInterkarma:masterfrom
Conversation
This allows changes of rulers to have appropriate title when %rt macro is used. Without this new rulers must be a Lord which is the default.
petchema
approved these changes
Mar 22, 2024
KABoissonneault
approved these changes
Mar 23, 2024
Collaborator
KABoissonneault
left a comment
KABoissonneault
left a comment
There was a problem hiding this comment.
The type can easily be set through the public FactionDict, but it's good to have this consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows changes of rulers to have appropriate title when %rt macro is used. Without this new rulers must be a Lord which is the default. No one is clamouring for this, but I realised that Cliff's change to add a ruler luckily is okay because it's a Lord but in future this could be useful.
Tested this with a bare bones quest script that prints the %rt macro. Happy to supply this if any reviewers want it.