Skip to content

Fixed "work question" sticking while moving from "Where Is?"#2598

Merged
KABoissonneault merged 1 commit intoInterkarma:masterfrom
KABoissonneault:fix/work-question
Feb 26, 2024
Merged

Fixed "work question" sticking while moving from "Where Is?"#2598
KABoissonneault merged 1 commit intoInterkarma:masterfrom
KABoissonneault:fix/work-question

Conversation

@KABoissonneault
Copy link
Copy Markdown
Collaborator

When transitioning from asking about "Where Is? Work" to "Tell Me About", the question at the top of the screen remains about work.

Daggerfall_Unity_2024.02.25_-_13.03.44.02.1.mp4

The "Where Is?" talk category is preserved when moving to "Tell Me About" so it can be restored when going back to "Where Is?".
The problem is that UpdateQuestion only checks the talk category "Work", not if we're actually in the "Where Is?" talk option.

I fixed this to also check the talk option

@KABoissonneault KABoissonneault added this to the DFU 1.0.1 milestone Feb 25, 2024
Copy link
Copy Markdown
Collaborator

@petchema petchema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KABoissonneault KABoissonneault merged commit 5b28ea0 into Interkarma:master Feb 26, 2024
@KABoissonneault KABoissonneault deleted the fix/work-question branch February 26, 2024 23:22
@KABoissonneault KABoissonneault mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants