Fix typo that breaks 3d object scaling in RMBLayout.cs#2566
Merged
KABoissonneault merged 1 commit intoInterkarma:masterfrom Jan 28, 2024
Merged
Fix typo that breaks 3d object scaling in RMBLayout.cs#2566KABoissonneault merged 1 commit intoInterkarma:masterfrom
KABoissonneault merged 1 commit intoInterkarma:masterfrom
Conversation
Collaborator
|
Not terribly comfortable with changing this at first glance, but I have to assume nothing in DF data actually has a Y scaling that differs from Z scaling, or else we would have seen this before. If so, that change seems fine Maybe I could write a script that traverses all DF models and ensures that my assumption is correct Affected DF objects:
|
Contributor
Author
|
Grep searching for the string "Scale" in a folder with all RMB jsons extracted from DF data shows that vanilla Daggerfall objects are never scaled at all. This change should only affect modded RMBs. |
KABoissonneault
approved these changes
Jan 26, 2024
numidium
approved these changes
Jan 27, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modders working with RMBs have known for a long time that rescaling 3d objects will break them. Either the scale will be wrong or objects will disappear entirely when scaled. The screenshot below demonstrates this bug with a modded RMB but otherwise unmodded game:
This bug turns out to be caused by a typo in the GetModelScaleVector method, in which obj.ZScale is incorrectly set to obj.YScale on line 76. Correcting this typo fixes the scaling bug:
