God's name localized in the "Donation" dialog#2550
God's name localized in the "Donation" dialog#2550KABoissonneault merged 3 commits intoInterkarma:masterfrom
Conversation
| { | ||
| string god = Temple.GetDivine(factionId).ToString(); | ||
| if (!string.IsNullOrEmpty(god)) | ||
| return TextManager.Instance.GetLocalizedText(god); |
There was a problem hiding this comment.
Should this use the factionId as key and the Factions collection? I'm not sure about how this works, but I don't think there are entries named after the gods
There was a problem hiding this comment.
Technically I could call GetLocalizedText in DaggerfallGuildServiceDonation.cs
Will it be a better solution?
There was a problem hiding this comment.
My mental map is a bit fuzzy here, but I can quickly confirm the following keys are present in the string tables.
Akatosh
Arkay
Dibella
Julianos
Kynareth
Mara
Stendarr
Zenithar
If the faction ID to string is guaranteed to always return one of those keys (case sensitive) in this process, then it's at least on the right track. I'd have to step through this one to be sure of the outcome however. Daggerfall being Daggerfall, there always seems to be some edge case I don't expect. :)
There was a problem hiding this comment.
Well, in this exact dialog we have a Macro Context, that overrides the %god macro, and the text is not translated.
Code review fixes
3 participants
God's name localized in the "Donation" dialog