Fix regression caused by #1861#2533
Merged
Interkarma merged 3 commits intoInterkarma:masterfrom Aug 9, 2023
Merged
Conversation
PR Interkarma#1861 was added to prevent caster enemies from nuking themselves with spells at range in the presence of low obstacles. A side effect of this PR however, is that daedra lords in the "crossbow room" near the end of Mantellan Crux stopped shooting at the player altogether, making this room much less threatening. This new PR checks for obstacles a bit in front of the enemies, so they can still cast from behind thin obstacles (rationale: spells start from arm's reach). It's a bit crude, for example it doesn't change from where the spells will be really cast, but from testing different casters (namely, beside Mantellan Crux's daedra lords: Karolys lich and Gortwog's shaman in entrance of Orsinium), I haven't experienced regressions.
Collaborator
Author
|
Casters from the main quest, for tests |
added 2 commits
August 2, 2023 18:32
DaggerfallMissile makes missiles originate in from of sender (position + dir * collisionRadius). Just make EnemyMotor make the same assumption.
Somewhat help Daedra Lords (and Sentinel's Wraith) cast more often. Casting from a higher position could also help Daedra Lords. I didn't want to add enemy type specific logic, though. Spell origin sphere is now disconnected from the caster's capsule (0.9 > 0.45 + 0.4), which must be why it works. I haven't found an example of caster trying to shoot the player with no visibility, but can it happen?
Collaborator
Author
|
Update: casting origin is now consistent between EnemyMotor and DaggerfallMissile, enemies should cast safely again. |
Owner
|
You're a treasure, thank you Pango! I appreciate the saves for testing. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1861 was added to prevent caster enemies from nuking themselves with spells at range in the presence of low obstacles.
A side effect of this PR however, is that daedra lords in the "crossbow room" near the end of Mantellan Crux stopped shooting at the player altogether, making this room much less threatening.
This new PR checks for obstacles a bit in front of the enemies, so they can still cast from behind thin obstacles (rationale: spells start from arm's reach). It's a bit crude, for example it doesn't change from where the spells will be really cast. While some spells get thru, daedra lords sometimes nuke themselves.