make sure dungeons's SongManager updates song with each dungeon#1632
Merged
Interkarma merged 1 commit intoInterkarma:masterfrom Dec 8, 2019
Merged
make sure dungeons's SongManager updates song with each dungeon#1632Interkarma merged 1 commit intoInterkarma:masterfrom
Interkarma merged 1 commit intoInterkarma:masterfrom
Conversation
Use OnTransitionDungeonInterior to update song based on dungeon. I don't expect we'll switch to full event-driven SongManager immediately, as song selection depends on many factors... Forums: https://forums.dfworkshop.net/viewtopic.php?f=24&t=3059
Collaborator
Author
|
OnTransitionDungeonInterior seems to be sufficient for game (re)loading updates |
Owner
|
This is a nice change all around. Not only fixes the initial problem, but makes the code a bit more readable too. Well done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use OnTransitionDungeonInterior to update song based on dungeon.
I don't expect we'll switch to full event-driven SongManager immediately, as song selection depends on many factors...
Forums: https://forums.dfworkshop.net/viewtopic.php?f=24&t=3059