dev-cmd/release: increase timeout to 15 minutes #21246
Conversation
We may need this for Apple's slow notarisation process.
There was a problem hiding this comment.
Pull request overview
This PR increases the timeout for the release workflow polling mechanism from 5 minutes to 15 minutes to accommodate Apple's potentially slow notarization process. The change modifies only the max_attempts value and its associated comment.
- Increases
max_attemptsfrom 60 to 180, tripling the timeout duration - Updates the inline comment to reflect the new 15-minute timeout
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| initial_sleep_time = 15 | ||
| sleep_time = 5 | ||
| max_attempts = 60 # 5 minutes (5 seconds * 60 attempts) | ||
| max_attempts = 180 # 15 minutes (5 seconds * 180 attempts) |
There was a problem hiding this comment.
The comment calculation is misleading. The actual timeout is slightly longer than 15 minutes because the first iteration sleeps for 15 seconds (initial_sleep_time) rather than 5 seconds. The actual timeout is: 15 + (179 * 5) = 910 seconds ≈ 15.17 minutes. Consider updating the comment to reflect this, for example: "approximately 15 minutes (15 + 179*5 seconds)"
| max_attempts = 180 # 15 minutes (5 seconds * 180 attempts) | |
| max_attempts = 180 # approximately 15 minutes (15 + 179*5 seconds = 910 seconds) |
We may need this for Apple's slow notarisation process.