Add URL fallbacks for deprecated formula and cask checks #21198

seivan · 2025-12-09T03:57:25Z

I find it it a bit frustrating having to do a brew info on each deprecated cask or formula to investigate why things are deprecated, so it would be nice to include URLs, but I didn't want to overload the list, so it will try to pick the best URL to show with the following fallbacks:

Formulas
homepage → head.url (git repo) → tap file URL

Casks
homepage → tap file URL

What's the existing output?

brew doctor                  

Warning: Some installed casks are deprecated or disabled.
You should find replacements for the following casks:
  syntax-highlight

What's the new output?

brew doctor                  

Warning: Some installed casks are deprecated or disabled.
You should find replacements for the following casks:
  syntax-highlight (https://github.com/sbarex/SourceCodeSyntaxHighlight)

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

Copilot

Pull request overview

This PR adds URL fallbacks to deprecated/disabled formula and cask diagnostics to help users investigate why packages are deprecated without needing to run brew info separately. The URLs are displayed inline using a prioritized fallback chain.

Key changes:

Added formula_tap_url and cask_tap_url helper methods to construct GitHub URLs for formula/cask files
Modified check_deprecated_disabled and check_cask_deprecated_disabled to include URLs in their output
Added comprehensive test coverage for the new helper methods and URL fallback logic

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
Library/Homebrew/diagnostic.rb	Adds URL fallback logic to deprecated/disabled checks with helper methods `formula_tap_url` and `cask_tap_url`
Library/Homebrew/test/diagnostic_checks_spec.rb	Adds comprehensive test coverage for the new URL helper methods and fallback behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Library/Homebrew/diagnostic.rb

Library/Homebrew/test/diagnostic_checks_spec.rb

Formulas `homepage` → `head.url (git repo)` → `tap file URL` Casks `homepage` → `tap file URL`

MikeMcQuaid · 2025-12-10T09:46:45Z

I find it it a bit frustrating having to do a brew info on each deprecated cask or formula to investigate why things are deprecated, so it would be nice to include URLs, but I didn't want to overload the list, so it will try to pick the best URL to show with the following fallbacks:

@seivan Let's step back a bit here: what problem are you trying to solve here? What's the existing output? Why don't you like that? What's the new output? What problems are solved with it?

Thanks!

seivan · 2025-12-11T13:08:12Z

@seivan Let's step back a bit here: what problem are you trying to solve here?

Access to information shouldn't take multiple steps.

What's the existing output?

brew doctor                  

Warning: Some installed casks are deprecated or disabled.
You should find replacements for the following casks:
  syntax-highlight

Why don't you like that?

Because it doesn't tell me why or where I can find more information or alternatives without doing a brew info on each.

What's the new output?

brew doctor                  

Warning: Some installed casks are deprecated or disabled.
You should find replacements for the following casks:
  syntax-highlight (https://github.com/sbarex/SourceCodeSyntaxHighlight)

What problems are solved with it?

@MikeMcQuaid It tells me what to lookup in case I want replacements or find a reason why or other work arounds.

MikeMcQuaid

All official formulae and casks have homepages so can simplify by skipping the fallbacks. Can remove any tests failing after this.

MikeMcQuaid · 2025-12-11T14:51:26Z

Library/Homebrew/diagnostic.rb

+          url = f.homepage.presence || f.head&.url.presence || formula_tap_url(f)
+          url ? "#{f.full_name} (#{Formatter.url(url)})" : f.full_name


Suggested change

url = f.homepage.presence || f.head&.url.presence || formula_tap_url(f)

url ? "#{f.full_name} (#{Formatter.url(url)})" : f.full_name

if (homepage = f.homepage.presence)

"#{f.full_name} (#{Formatter.url(homepage)})"

else

f.full_name

end

MikeMcQuaid · 2025-12-11T14:52:07Z

Library/Homebrew/diagnostic.rb

+      sig { params(formula: Formula).returns(T.nilable(String)) }
+      def formula_tap_url(formula)
+        tap = formula.tap
+        return if tap.blank? || tap.remote.blank?
+
+        path = formula.path.relative_path_from(tap.path)
+        "#{tap.remote}/blob/HEAD/#{path}"
+      end
+


Suggested change

sig { params(formula: Formula).returns(T.nilable(String)) }

def formula_tap_url(formula)

tap = formula.tap

return if tap.blank? || tap.remote.blank?

path = formula.path.relative_path_from(tap.path)

"#{tap.remote}/blob/HEAD/#{path}"

end

MikeMcQuaid · 2025-12-11T14:52:20Z

Library/Homebrew/diagnostic.rb

+      sig { params(cask: Cask::Cask).returns(T.nilable(String)) }
+      def cask_tap_url(cask)
+        tap = cask.tap
+        return if tap.blank? || tap.remote.blank?
+
+        "#{tap.remote}/blob/HEAD/#{tap.relative_cask_path(cask.token)}"
+      end


Suggested change

sig { params(cask: Cask::Cask).returns(T.nilable(String)) }

def cask_tap_url(cask)

tap = cask.tap

return if tap.blank? || tap.remote.blank?

"#{tap.remote}/blob/HEAD/#{tap.relative_cask_path(cask.token)}"

end

MikeMcQuaid · 2025-12-11T14:53:23Z

Library/Homebrew/diagnostic.rb

+          url = c.homepage.presence || cask_tap_url(c)
+          url ? "#{c.token} (#{Formatter.url(url)})" : c.token


Suggested change

url = c.homepage.presence || cask_tap_url(c)

url ? "#{c.token} (#{Formatter.url(url)})" : c.token

if (homepage = c.homepage.presence)

"#{c.token} (#{Formatter.url(homepage)})"

else

c.token

end

@MikeMcQuaid If all of them have homepages, why do we check for c.homepage.presence?

@seivan broken or non-homebrew core formulae may not.

You mean taps? I think we should keep the fallbacks in that case, a lot of people use taps. In fact I made one recently because of the gatekeeper issues. It's a diagnostic tool, it should diagnose things that are broken, no?

@seivan I don't think for this debugging tool we should handle the edge cases of "deprecated formulae in taps that fail audits and/or are otherwise broken". It's not worth the extra code.

seivan force-pushed the feature/deprecated_url branch 2 times, most recently from ec3f2c7 to 9f91943 Compare December 9, 2025 04:02

seivan marked this pull request as ready for review December 9, 2025 04:08

Copilot AI review requested due to automatic review settings December 9, 2025 04:08

Copilot started reviewing on behalf of seivan December 9, 2025 04:09 View session

Copilot AI reviewed Dec 9, 2025

View reviewed changes

Library/Homebrew/diagnostic.rb Outdated Show resolved Hide resolved

Library/Homebrew/diagnostic.rb Outdated Show resolved Hide resolved

Library/Homebrew/test/diagnostic_checks_spec.rb Show resolved Hide resolved

Add URL fallbacks for checking deprecated formula or casks.

5ad2ae7

Formulas `homepage` → `head.url (git repo)` → `tap file URL` Casks `homepage` → `tap file URL`

seivan force-pushed the feature/deprecated_url branch from 9f91943 to 5ad2ae7 Compare December 9, 2025 04:41

MikeMcQuaid reviewed Dec 11, 2025

View reviewed changes

		url = f.homepage.presence \|\| f.head&.url.presence \|\| formula_tap_url(f)
		url ? "#{f.full_name} (#{Formatter.url(url)})" : f.full_name

		url = c.homepage.presence \|\| cask_tap_url(c)
		url ? "#{c.token} (#{Formatter.url(url)})" : c.token

Uh oh!

Add URL fallbacks for deprecated formula and cask checks #21198

Are you sure you want to change the base?

Add URL fallbacks for deprecated formula and cask checks #21198

Conversation

seivan commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MikeMcQuaid commented Dec 10, 2025

Uh oh!

seivan commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MikeMcQuaid left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

seivan commented Dec 9, 2025 •

edited

Loading

seivan commented Dec 11, 2025 •

edited

Loading