added setMisc and getMisc#579
Merged
janaobsteter merged 3 commits intoHighlanderLab:develfrom Jul 17, 2024
Merged
Conversation
Contributor
Author
|
See #578 |
Contributor
Author
|
@gregorgorjanc, I've made several changes to attempt to get the package to work with both the current version of AlphaSimR and the devel version with the changes to the misc slot. I think everything should work against the current AlphaSImR version and you should get speed ups to The code isn't working for the devel version yet. I've only made some very quick changes and everything was working against your unit tests. However, I seeing one of the examples fail. |
janaobsteter
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
miscis slot is getting reworked in the new version of AlphaSimR and it will break SIMplyBee.I added versions of
setMiscandgetMischere that should work with both the new and old versions of AlphaSimR.However, this doesn't completely fix the problem since there are several places where SIMplyBee pulls form the slots directly. These will have to be reworked. I suggest trying to rework them by rerouting through
setMiscandgetMiscso that the code will be robust to the AlphaSimR version.