Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 97.44% 98.95% +1.50%
==========================================
Files 38 38
Lines 941 960 +19
==========================================
+ Hits 917 950 +33
+ Misses 24 10 -14
☔ View full report in Codecov by Sentry. |
|
I made a PR to this CI branch, it fixes the test failures.
There was some aggressive caching going on server side. So while the movies where done, the API would still return the cached status of "Queued" causing the test to time out when it shouldn't.
This was IRIS which I recently added to HV.
This was another server side issue. the png it's claiming it can't find is a little highlighted active region that gets overlayed on the screenshot. The file was in the db but wasn't on disk. I'm not sure why this happened, but it should be fixed for this and all future screenshots. |
* Add IRIS and GONG datasources * Update timeout test to have a shorter timeout * Fix codestyle * Increase test timeout to 2 minutes
|
build_docs is still failing. Looks like it has to do with the pydantic 2.0 version bump |
|
Thanks, I will look into and patch it now. |
|
That seems like a bug upstream in pydanatic. It only creates a warning which does not affect the final documentation build. I will try to see if I can replicate it in a simpler env and report upstream. |
|
@dgarciabriseno Would you ok with doing a release of this, or shall I tag it? Also I feel with the bump in pydanatic, a 1.1.0 version feels more appropriate? |
|
Yep, I can tag it. |
|
I forgot to check if the release job requires the docs build to pass, if so we will need to change that and update the tagged commit. |
|
Yea it doesn't reach publish with docs build failing |
Fixes #96
TODO:
Work out why some of the movie tests timeout
Work out why the screenshot return is not a URL
Work out what source ID 37 is and add it.