Reduce example output for getstatus's doctest#91
Reduce example output for getstatus's doctest#91dgarciabriseno merged 2 commits intoHelioviewer-Project:mainfrom
Conversation
It breaks due to ordering issues.
dgarciabriseno
force-pushed
the
skip-getstatus
branch
from
6289b84 to
9132fcc
Compare
hvpy/facade.py
Outdated
| >>> from hvpy import getStatus | ||
| >>> getStatus() | ||
| {'AIA': ..., 'COSMO': ..., 'HMI': ..., 'LASCO': ..., 'SECCHI': ..., 'SWAP': ..., 'XRT': ...} | ||
| >>> getStatus() # doctest: +SKIP |
There was a problem hiding this comment.
Its a shame it keeps changing, I wonder if we want to sort the return in future?
There was a problem hiding this comment.
Even sorted it would break again when a new source is added.
Does this support partial objects? Could I have it check:
{'AIA': ..., ...}
That would verify that at least something is returned.
There was a problem hiding this comment.
Looks like it worked a treat. Lets hope no one launches ABA soon.
Codecov ReportBase: 98.93% // Head: 98.93% // No change to project coverage 👍
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage 98.93% 98.93%
=======================================
Files 38 38
Lines 941 941
=======================================
Hits 931 931
Misses 10 10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dgarciabriseno
changed the title
3 participants
It breaks whenever the ordering of keys in the JSON object changes.