Conversation
nabobalis
commented
Oct 17, 2022
Member
Author
|
I would like to get a 1.0.1 out of the door with this PR. |
nabobalis
requested review from
akash5100 and
dgarciabriseno
and removed request for
dgarciabriseno
nabobalis
commented
Oct 17, 2022
| if filename.exists() and not overwrite: | ||
| raise FileExistsError(f"{filename} already exists. Use overwrite=True to overwrite.") | ||
| filename.write_bytes(data) | ||
| return filename |
Member
Author
There was a problem hiding this comment.
Was there a reason to not do this?
It is quite useful to get the return and so I can pass that filepath into another function.
Collaborator
There was a problem hiding this comment.
Actually, I don't recall. It is better now.
nabobalis
changed the title
nabobalis
changed the title
nabobalis
changed the title
nabobalis
changed the title
save_file now cleans the filename, expands user and returns the full file path
Codecov ReportBase: 99.29% // Head: 99.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
=======================================
Coverage 99.29% 99.30%
=======================================
Files 25 25
Lines 711 716 +5
=======================================
+ Hits 706 711 +5
Misses 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
akash5100
reviewed
Oct 18, 2022
akash5100
approved these changes
Oct 18, 2022
dgarciabriseno
approved these changes
Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83
Cleans filename, expands users and returns the filename now.
We also forgot to delete the old changelog file and point users to where the "changelogs" are kept.