Skip to content

use res['title'] to as a new filename #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nabobalis merged 6 commits into from
Oct 17, 2022
Merged

use res['title'] to as a new filename #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
776ed2c
use res['title'] to rename the file
akash5100 Oct 1, 2022
d15f832
filename tweaks
akash5100 Oct 3, 2022
9748a90
fix failing test
akash5100 Oct 4, 2022
37133d7
minimize the changes
akash5100 Oct 4, 2022
5308472
Change the get title condition, moved it into the condition when stat…
akash5100 Oct 7, 2022
54c9a33
change the getJP2Header example to pass the failing test
akash5100 Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hvpy/facade.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def getJP2Header(
--------
>>> from hvpy import getJP2Header
>>> getJP2Header(id=7654321,callback="xml_header")
'xml_header(\\\'<?xml version="1.0" encoding="utf-8"?><meta><fits><SIMPLE>1</SIMPLE><BITPIX>16</BITPIX>...')'
'xml_header(\\\'<?xml version="1.0" encoding="utf-8"?><meta><fits>...')'
"""
params = getJP2HeaderInputParameters(id=id, callback=callback)
return execute_api_call(input_parameters=params)
Expand Down
6 changes: 4 additions & 2 deletions hvpy/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def createMovie(
Default is `False`.
filename
The path to save the file to.
Optional, will default to ``f"{res['id']}_{startTime.date()}_{endTime.date()}.{format}"``.
Optional, will default to ``f"{res['title']}.{format}"``.
hq
Download a higher-quality movie file (valid for "mp4" movies only, ignored otherwise).
Default is `False`, optional.
Expand Down Expand Up @@ -97,6 +97,7 @@ def createMovie(
if res.get("error"):
raise RuntimeError(res["error"])
timeout_counter = time.time() + 60 * timeout # Default 5 minutes
title = ""
while True:
status = getMovieStatus(
id=res["id"],
Expand All @@ -106,6 +107,7 @@ def createMovie(
if status["status"] in [0, 1]:
time.sleep(3)
if status["status"] == 2:
title = status["title"]
break
if time.time() > timeout_counter:
raise RuntimeError(f"Exceeded timeout of {timeout} minutes.")
Expand All @@ -117,7 +119,7 @@ def createMovie(
hq=hq,
)
if filename is None:
filename = f"{res['id']}_{startTime.date()}_{endTime.date()}.{format}"
filename = f"{title}.{format}"
else:
filename = f"{filename}.{format}"
save_file(
Expand Down