EventType enum#70
Merged
dgarciabriseno merged 6 commits intoHelioviewer-Project:mainfrom Aug 24, 2022
Merged
Conversation
Collaborator
akash5100
commented
Aug 23, 2022
akash5100
commented
- closes Add enum for event types #62
Codecov Report
@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 99.48% 99.51% +0.02%
==========================================
Files 23 24 +1
Lines 586 622 +36
==========================================
+ Hits 583 619 +36
Misses 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
Looks good to me, I would want Daniel to review it before a merge. |
nabobalis
approved these changes
Aug 23, 2022
Member
nabobalis
left a comment
nabobalis
left a comment
There was a problem hiding this comment.
I want Daniel to double check
nabobalis
approved these changes
Aug 23, 2022
Member
nabobalis
left a comment
nabobalis
left a comment
There was a problem hiding this comment.
I want Daniel to double check
dgarciabriseno
approved these changes
Aug 24, 2022
Collaborator
dgarciabriseno
left a comment
dgarciabriseno
left a comment
There was a problem hiding this comment.
Looks ok to me, not sure if the test is needed here, though.
Member
|
We can remove it but I feel like there isn't any harm for now with it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.