Skip to content

Rename DataSources enum to DataSource#69

Merged
nabobalis merged 3 commits intoHelioviewer-Project:mainfrom
akash5100:rename_datasource_enum
Aug 23, 2022
Merged

Rename DataSources enum to DataSource#69
nabobalis merged 3 commits intoHelioviewer-Project:mainfrom
akash5100:rename_datasource_enum

Conversation

@akash5100
Copy link
Collaborator

@akash5100 akash5100 requested a review from nabobalis August 23, 2022 08:56
@akash5100 akash5100 self-assigned this Aug 23, 2022
@nabobalis
Copy link
Member

nabobalis commented Aug 23, 2022

I think we need to rename the file to drop the s as well.

Any place that has datasources should be singular now.

@nabobalis
Copy link
Member

I think the API page will need changing?

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Merging #69 (6938daa) into main (c8d31f5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          23       23           
  Lines         599      599           
=======================================
  Hits          596      596           
  Misses          3        3           
Impacted Files Coverage Δ
hvpy/datasource.py 100.00% <100.00%> (ø)
hvpy/utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@akash5100
Copy link
Collaborator Author

Okay

@nabobalis nabobalis merged commit 89122f1 into Helioviewer-Project:main Aug 23, 2022
@akash5100 akash5100 deleted the rename_datasource_enum branch August 23, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename enum "Datasources" to "Datasource"

3 participants

Comments