Enum for Datasources#61
Merged
nabobalis merged 12 commits intoHelioviewer-Project:mainfrom Aug 20, 2022
Merged
Conversation
Collaborator
akash5100
commented
Aug 18, 2022
akash5100
commented
- closes Add ENUM for data sources #50
nabobalis
reviewed
Aug 18, 2022
Member
|
I think a new AI page needs to be created for this, or this enum needs to be imported into another init file. Maybe the highest level one. |
Member
|
Also a basic test that imports the enum and checks it works. |
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 99.14% 99.48% +0.34%
==========================================
Files 21 23 +2
Lines 351 586 +235
==========================================
+ Hits 348 583 +235
Misses 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
Typo, I meant API |
nabobalis
approved these changes
Aug 18, 2022
nabobalis
reviewed
Aug 18, 2022
nabobalis
reviewed
Aug 20, 2022
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
nabobalis
approved these changes
Aug 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.