downloadMovie endpoint#57
Merged
nabobalis merged 4 commits intoHelioviewer-Project:mainfrom Aug 14, 2022
Merged
Conversation
Collaborator
akash5100
commented
Aug 14, 2022
akash5100
commented
- closes Movies - downloadMovie endpoint #12
Codecov Report
@@ Coverage Diff @@
## main #57 +/- ##
==========================================
+ Coverage 99.04% 99.07% +0.03%
==========================================
Files 18 19 +1
Lines 314 326 +12
==========================================
+ Hits 311 323 +12
Misses 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nabobalis
reviewed
Aug 14, 2022
nabobalis
reviewed
Aug 14, 2022
nabobalis
reviewed
Aug 14, 2022
|
|
||
| id: str | ||
| format: str | ||
| hq: Optional[bool] = False |
Member
There was a problem hiding this comment.
Suggested change
| hq: Optional[bool] = False | |
| hq: bool = False |
Optional is only if the value can be set to None, it does not mean if its optional from a user's point of view.
Collaborator
Author
There was a problem hiding this comment.
Okay, understood
Because in the facade function we already have the Optional parameter, right?
Member
There was a problem hiding this comment.
No. You set the default value, that makes it optional.
nabobalis
reviewed
Aug 14, 2022
nabobalis
reviewed
Aug 14, 2022
nabobalis
reviewed
Aug 14, 2022
nabobalis
approved these changes
Aug 14, 2022
nabobalis
reviewed
Aug 14, 2022
Member
|
Another one down! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.