Switch the baseurl with set_api#41
Conversation
akash5100
commented
Jul 16, 2022
- Closes Add a way to change the BASEURL #24
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 12 +1
Lines 172 196 +24
=========================================
+ Hits 172 196 +24
Continue to review full report at Codecov.
|
hvpy/io.py
Outdated
| if "PRIVATE_URL" in os.environ: | ||
| return os.environ["PRIVATE_URL"] + self.__class__.__name__[:-15] + "/" |
There was a problem hiding this comment.
This I assume is now not needed?
There was a problem hiding this comment.
This needs to move to initialize _base_url
There was a problem hiding this comment.
So, I think we will need another function (get_api_url) as you said.
see: #41 (comment)
dgarciabriseno
left a comment
There was a problem hiding this comment.
Change PRIVATE_URL to something more specific to hvpy. Remember the environment contains variables that are passed to every program that runs on a system, so "PRIVATE_URL" is too vague.
Let's use HELIOVIEWER_API_URL