JPEG2000 endpoints#34
Merged
dgarciabriseno merged 35 commits intoHelioviewer-Project:mainfrom Jul 8, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #34 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 10 +4
Lines 79 133 +54
=========================================
+ Hits 79 133 +54
Continue to review full report at Codecov.
|
nabobalis
reviewed
Jul 4, 2022
nabobalis
reviewed
Jul 4, 2022
nabobalis
reviewed
Jul 4, 2022
nabobalis
reviewed
Jul 4, 2022
nabobalis
reviewed
Jul 4, 2022
This was
linked to
issues
Jul 4, 2022
nabobalis
reviewed
Jul 5, 2022
hvpy/api_groups/jpeg2000/tests/test_get_jpx_closest_to_mid_point.py
Outdated
Show resolved
Hide resolved
nabobalis
reviewed
Jul 5, 2022
nabobalis
reviewed
Jul 5, 2022
Member
|
I pushed a change for the reusable validators using the docs example from pydantic. |
nabobalis
approved these changes
Jul 7, 2022
Member
|
The file conflict will need resolving before we can merge this. |
…into jpeg2000_endpoints
Co-authored-by: Daniel Garcia Briseno <94071409+dgarciabriseno@users.noreply.github.com>
akash5100
commented
Jul 8, 2022
dgarciabriseno
approved these changes
Jul 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6
Fixes #8
Fixes #5
Fixes #7