Skip to content

Template Repo#1

Merged
dgarciabriseno merged 2 commits intoHelioviewer-Project:mainfrom
nabobalis:main
May 25, 2022
Merged

Template Repo#1
dgarciabriseno merged 2 commits intoHelioviewer-Project:mainfrom
nabobalis:main

Conversation

@nabobalis
Copy link
Member

@nabobalis nabobalis commented May 23, 2022

Todo:

  • Get a review
  • Add actions CI
  • more to come when I recall what it was

For a follow up?

  • set up RTD hook
  • codecov?

setup.cfg Outdated
[metadata]
name = hvpy
author = Helioviewer Project
author_email = add@email.com
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wafels
Should we still use contact@helioviewer.org

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this for the time being.

@@ -0,0 +1,5 @@
v0.0.1 (2022-11-11)
Copy link
Member Author

@nabobalis nabobalis May 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided that just manually editing a changelog file is probably all we need instead of a more complex system.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's alright

@nabobalis
Copy link
Member Author

For me to check the CI is working as expected, we need to merge this in first and then see if actions is happy.

Comment on lines +5 to +12
"""
_summary_

Returns
-------
_type_
_description_
"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these comments get parsed into the docs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They will be, I just created this to ensure the doc build works.

@nabobalis nabobalis marked this pull request as ready for review May 25, 2022 16:25
@dgarciabriseno dgarciabriseno merged commit 884b4c9 into Helioviewer-Project:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments