Skip to content

BuildPDAF: Add -fcommon to Fortran/C optimization flags#79

Merged
jjokella merged 1 commit intomasterfrom
dev-fcommon
Jul 10, 2025
Merged

BuildPDAF: Add -fcommon to Fortran/C optimization flags#79
jjokella merged 1 commit intomasterfrom
dev-fcommon

Conversation

@jjokella
Copy link
Copy Markdown
Contributor

@jjokella jjokella commented Jul 9, 2025

Goal: remove multiple-definition errors for GCC compilers.

For more information, see HPSCTerrSys/pdaf#8

Goal: remove multiple-definition errors
@kvrigor
Copy link
Copy Markdown
Member

kvrigor commented Jul 10, 2025

@jjokella Is this part of a larger effort related to fixing GCC issues on PDAF? Maybe it makes more sense for #78 and #79 to be a single PR.

@jjokella
Copy link
Copy Markdown
Contributor Author

Hey @kvrigor, actually current build-checks indicate that these three PRs #77 #78 and #79 are enough to ensure compilation.

Maybe they are a little to scattered? But I think I would leave them now as is.

@kvrigor
Copy link
Copy Markdown
Member

kvrigor commented Jul 10, 2025

Maybe they are a little to scattered? But I think I would leave them now as is.

I think so too; I try to combine related commits so that TSMP2's git log is a nice series of feature sets instead of a bunch of micro-commits without a broader context. For now I'll approve the PRs.

@kvrigor kvrigor assigned kvrigor and unassigned kvrigor Jul 10, 2025
@kvrigor kvrigor self-requested a review July 10, 2025 13:28
@jjokella
Copy link
Copy Markdown
Contributor Author

Will keep this in mind for future development

@jjokella jjokella merged commit 5c804d2 into master Jul 10, 2025
1 check passed
@jjokella jjokella deleted the dev-fcommon branch July 10, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants