-
Notifications
You must be signed in to change notification settings - Fork 6.7k
dataflow: update Dockerfile and modularize tests #5692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dataflow: update Dockerfile and modularize tests #5692
Conversation
…amples into dataflow-flex-templates
…amples into dataflow-flex-templates
…amples into dataflow-flex-templates
…hon-docs-samples into dataflow-flex-templates
…amples into dataflow-flex-templates
…amples into dataflow-flex-templates
…amples into dataflow-flex-templates
…amples into dataflow-flex-templates
…amples into dataflow-flex-templates
…amples into dataflow-flex-templates
|
It looks like tests are passing. It now waits until the job is running (typically 2-3 minutes), then waits 1 minute for data to come in, and cancels the job. |
|
@leahecole @dandhlee tests are passing, and comments addressed. If there are no other comments, this might be ready to merge :) |
|
Dan is OOO today but he'll look when he's back! |
dandhlee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor comment below. Thank you!
|
All tests are passing. I'll merge this for now to unblock writing other tests. If we want to revisit and remove the unused utility function, I'll do it in a separate PR. |
Description
Updating the Dockerfile, but while doing that I updated the test to make it e2e and actually test the image creation. There's been a lot of code duplication in tests so I tried to modularize common functions into their own file. I'll migrate other tests to use that module later on.
Checklist
nox -s py-3.6(see Test Environment Setup)nox -s lint(see Test Environment Setup)