Add GAE standard + firebase tictactoe sample #358

jerjou · 2016-10-11T04:07:47Z

This is my first pass at this. I copied the channel api sample to start, so there might be some vestigial stuff from that. I'm going to make another clean-up pass on this, but I figured I'd send it out sooner rather than later so you can start taking a look.

FYI this is on GAE standard, just 'cuz the channel api was on standard. Think it's worth it to put it on flex?

codecov-io · 2016-10-11T04:23:22Z

Current coverage is 48.19% (diff: 100%)

Merging #358 into master will not change coverage

@@             master       #358   diff @@
==========================================
  Files            73         73          
  Lines          2268       2268          
  Methods           0          0          
  Messages          0          0          
  Branches        158        158          
==========================================
  Hits           1093       1093          
  Misses         1145       1145          
  Partials         30         30

Powered by Codecov. Last update 9474200...e9ed5e2

lesv

Good start.

Why use both Objectify and Firebase?
Should use new maven plugin.
Could use a few comments everywhere - esp. where api's are used.
Either do something on exceptions or don't catch them.
Why use old nomenclature? channelId?

lesv · 2016-10-11T04:44:44Z

appengine/firebase-tictactoe/pom.xml

+        <relativePath>../..</relativePath>
+    </parent>
+    <properties>
+        <objectify.version>5.1.13</objectify.version>


Is this used?

Yeah. I never really got the point of specifying the version numbers as a separate property, though, so if you don't know either, I can just specify it as a literal in the dependency section ;)

No the repo-gardener requires it to be in properties, so thats a good thing.

Yeah, for whatever reason the versions plugin can detect version upgrades for plugins, but it can only update properties and dependency versions, not plugin versions directly.

lesv · 2016-10-11T04:45:10Z

appengine/firebase-tictactoe/pom.xml

+            <scope>provided</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.json</groupId>


Is this used?

Yeah - communicating with firebase is all through json

I typically use this as it's very easy to use, but consider Google GSON. I'm trying to switch.

lesv · 2016-10-11T04:45:18Z

appengine/firebase-tictactoe/pom.xml

+            <version>20160810</version>
+        </dependency>
+        <dependency>
+            <groupId>com.googlecode.objectify</groupId>


Is this used?

Yup - in this app, datastore is the canonical representation of the game board, and we use objectify to persist it.

lesv · 2016-10-11T04:46:14Z

appengine/firebase-tictactoe/pom.xml

+        <plugins>
+            <!-- Parent POM defines ${appengine.sdk.version} (updates frequently). -->
+            <plugin>
+                <groupId>com.google.appengine</groupId>


Old plugin, please use the new one.

Ugh... oddly enough, switching to the new plugin causes firebase calls to fail..
Updating for now. Working on getting it to work with the new plugin..

@GoogleCloudPlatform/cloud-tools-for-java FYI

lesv · 2016-10-11T04:46:48Z

appengine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/DeleteServlet.java

+  public void doPost(HttpServletRequest req, HttpServletResponse resp)
+      throws IOException {
+    UserService userService = UserServiceFactory.getUserService();
+    String gameId = req.getParameter("g");


"g" -- shouldn't it be a bit longer?

I dunno - this is what the python query parameter was. The channel sample alternated between calling it "g" and "gameKey".

shrug Updated to be more descriptive.

lesv · 2016-10-11T04:55:47Z

appengine/firebase-tictactoe/src/main/webapp/resources/firebase_config.html

+  var config = {
+    apiKey: "AIzaSyC3gJDK1r-8nZuJGdmXntJR4E8cqH8qSTk",
+    authDomain: "channels-api-deprecation.firebaseapp.com",
+    databaseURL: "https://channels-api-deprecation.firebaseio.com",


lesv · 2016-10-11T04:55:54Z

appengine/firebase-tictactoe/src/main/webapp/resources/firebase_config.html

+    apiKey: "AIzaSyC3gJDK1r-8nZuJGdmXntJR4E8cqH8qSTk",
+    authDomain: "channels-api-deprecation.firebaseapp.com",
+    databaseURL: "https://channels-api-deprecation.firebaseio.com",
+    storageBucket: "channels-api-deprecation.appspot.com",


lesv · 2016-10-11T04:56:01Z

appengine/firebase-tictactoe/src/main/webapp/resources/firebase_config.html

+    authDomain: "channels-api-deprecation.firebaseapp.com",
+    databaseURL: "https://channels-api-deprecation.firebaseio.com",
+    storageBucket: "channels-api-deprecation.appspot.com",
+    messagingSenderId: "542117602304"


lesv · 2016-10-11T04:59:24Z

appengine/firebase-tictactoe/src/main/webapp/WEB-INF/appengine-web.xml

+ limitations under the License.
+-->
+<appengine-web-app xmlns="http://appengine.google.com/ns/1.0">
+    <application>YOUR-PROJECTID-HERE</application>


lowercase will work better w/ new plugin.

lesv · 2016-10-11T04:59:35Z

appengine/firebase-tictactoe/src/main/webapp/WEB-INF/appengine-web.xml

+-->
+<appengine-web-app xmlns="http://appengine.google.com/ns/1.0">
+    <application>YOUR-PROJECTID-HERE</application>
+    <version>1</version>


No longer required.

jerjou

Okay - I ran into a problem when actually deploying the app (plus the whole new-maven-plugin not working, which might be related), so working on that. But for the moment, I've pushed some updates to this PR.

jerjou · 2016-10-11T17:58:15Z

appengine/firebase-tictactoe/pom.xml

+            <scope>provided</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.json</groupId>


Yeah - communicating with firebase is all through json

jerjou · 2016-10-11T18:18:56Z

appengine/firebase-tictactoe/pom.xml

+        <relativePath>../..</relativePath>
+    </parent>
+    <properties>
+        <objectify.version>5.1.13</objectify.version>


Yeah. I never really got the point of specifying the version numbers as a separate property, though, so if you don't know either, I can just specify it as a literal in the dependency section ;)

jerjou · 2016-10-11T18:20:30Z

appengine/firebase-tictactoe/pom.xml

+            <version>20160810</version>
+        </dependency>
+        <dependency>
+            <groupId>com.googlecode.objectify</groupId>


Yup - in this app, datastore is the canonical representation of the game board, and we use objectify to persist it.

jerjou · 2016-10-11T23:56:24Z

appengine/firebase-tictactoe/pom.xml

+        <plugins>
+            <!-- Parent POM defines ${appengine.sdk.version} (updates frequently). -->
+            <plugin>
+                <groupId>com.google.appengine</groupId>


Ugh... oddly enough, switching to the new plugin causes firebase calls to fail..
Updating for now. Working on getting it to work with the new plugin..

jerjou · 2016-10-11T23:58:24Z

appengine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/DeleteServlet.java

+  public void doPost(HttpServletRequest req, HttpServletResponse resp)
+      throws IOException {
+    UserService userService = UserServiceFactory.getUserService();
+    String gameId = req.getParameter("g");


I dunno - this is what the python query parameter was. The channel sample alternated between calling it "g" and "gameKey".

shrug Updated to be more descriptive.

jerjou · 2016-10-12T00:09:39Z

...ngine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/GetTokenServlet.java

+
+    String currentUserId = userService.getCurrentUser().getUserId();
+    if (currentUserId.equals(game.getUserX()) || currentUserId.equals(game.getUserO())) {
+      /*


Oh yeah - I just commented this out in anticipation of filling it in later, but turns out this servlet isn't actually referenced anywhere so I'll just delete it.

jerjou · 2016-10-12T00:13:59Z

appengine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/MoveServlet.java

+      throws IOException {
+    UserService userService = UserServiceFactory.getUserService();
+    String gameId = req.getParameter("g");
+    int piece = new Integer(req.getParameter("i"));


Updated to be more descriptive

jerjou · 2016-10-12T00:20:24Z

...gine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/TicTacToeServlet.java

+    // 4. More general template values
+    req.setAttribute("game_key", gameKey);
+    req.setAttribute("me", userId);
+    req.setAttribute("channel_id", channelId);


Yup - the "channel id" is now a unique identifier on the firebase side that the server posts updates to, and the client listens to for updates.

jerjou · 2016-10-12T00:23:15Z

appengine/firebase-tictactoe/src/main/webapp/resources/firebase_config.html

+<script>
+  // Initialize Firebase
+  var config = {
+    apiKey: "AIzaSyC3gJDK1r-8nZuJGdmXntJR4E8cqH8qSTk",


Oh whoops. Yes.

jerjou · 2016-10-12T00:23:24Z

appengine/firebase-tictactoe/src/main/webapp/resources/firebase_config.html

+  // Initialize Firebase
+  var config = {
+    apiKey: "AIzaSyC3gJDK1r-8nZuJGdmXntJR4E8cqH8qSTk",
+    authDomain: "channels-api-deprecation.firebaseapp.com",


Added a README with setup steps.

lesv · 2016-10-12T16:40:17Z

appengine/firebase-tictactoe/README.md

+
+* If you see the error `Google Cloud SDK path was not provided ...`:
+    * Make sure you've installed the [Google cloud SDK][sdk]
+    * You may have installed it in a non-standard path. In that case, set the


Good point - you might mention that the Google Cloud SDK needs to be on your PATH, if not, you can fix it by adding...

lesv · 2016-10-12T16:41:38Z

appengine/firebase-tictactoe/pom.xml

+        <relativePath>../..</relativePath>
+    </parent>
+    <properties>
+        <objectify.version>5.1.13</objectify.version>


No the repo-gardener requires it to be in properties, so thats a good thing.

lesv · 2016-10-12T16:42:50Z

appengine/firebase-tictactoe/pom.xml

+            <scope>provided</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.json</groupId>


I typically use this as it's very easy to use, but consider Google GSON. I'm trying to switch.

lesv · 2016-10-12T16:43:47Z

appengine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/Game.java

+    return firebaseSnippet.substring(openQuote + 1, closeQuote);
+  }
+
+  Game() {


You might wish to set an ID here.

lesv · 2016-10-12T16:45:01Z

...gine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/TicTacToeServlet.java

+    // 4. More general template values
+    req.setAttribute("game_key", gameKey);
+    req.setAttribute("me", userId);
+    req.setAttribute("channel_id", channelId);


Should it be renamed?

elharo · 2016-10-12T18:09:34Z

appengine/firebase-tictactoe/README.md

+# Tic Tac Toe on Google App Engine Standard using Firebase
+
+This directory contains a project that implements a realtime two-player game of
+Tic Tac Toe on [Google App Engine] Standard, using the [Firebase] database


I'd put Standard inside the link and link to https://cloud.google.com/appengine/docs/about-the-standard-environment instead

elharo · 2016-10-12T18:10:28Z

appengine/firebase-tictactoe/README.md

+
+## Prerequisites
+
+* Install [Apache Maven][maven]


3.3.9 or later

It used to be the case for the old appengine plugin, but I've been using mvn 3.0.5 with our plugin and it hasn't complained.

elharo · 2016-10-12T18:10:57Z

appengine/firebase-tictactoe/README.md

+* Install [Apache Maven][maven]
+* Create a project in the [Firebase Console][fb-console]
+* Install the [Google Cloud SDK][sdk]
+* Download [service account credentials][creds] and move it to


elharo · 2016-10-12T18:12:40Z

appengine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/DeleteServlet.java

+
+public class DeleteServlet extends HttpServlet {
+  @Override
+  public void doPost(HttpServletRequest req, HttpServletResponse resp)


req --> request
resp --> response
since Google Java style avoids abbreviatiosn

DevRel is a bit more relaxed on this.

elharo · 2016-10-12T18:13:23Z

appengine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/Game.java

+  static {
+    try {
+      sFirebaseSnippet = CharStreams.toString(
+          new InputStreamReader(new FileInputStream(FIREBASE_SNIPPET_PATH)));


needs character encoding specified

elharo · 2016-10-12T18:13:48Z

appengine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/Game.java

+          .setDatabaseUrl(sFirebaseDbUrl)
+          .build();
+      FirebaseApp.initializeApp(options);
+    } catch (Exception e) {


try to catch a more specfic exception if possible

elharo · 2016-10-12T18:15:19Z

appengine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/OfyHelper.java

+ * OfyHelper, a ServletContextListener, is setup in web.xml to run before a JSP is run.  This is
+ * required to let JSP's access Ofy.
+ **/
+public class OfyHelper implements ServletContextListener {


ObjectifyHelper

joaoandremartins · 2016-10-12T21:18:26Z

appengine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/MoveServlet.java

+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+public class MoveServlet extends HttpServlet {


Some Javadoc for this class?

At least some comments, if not full JavaDoc

joaoandremartins · 2016-10-12T21:18:43Z

appengine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/OpenedServlet.java

+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+public class OpenedServlet extends HttpServlet {


Javadoc for this class?

jerjou · 2016-10-13T02:40:34Z

Pushed another iteration. Not all the comments were addressed yet - of note, I haven't figured out how to use Guice yet -_-;

lesv · 2016-10-13T02:42:31Z

Take a look at the Objectify Guestbook in flexible/

tswast · 2016-10-13T16:22:08Z

I'd recommend Dagger 2 over Guice. Guice is runtime dependency injection and dagger is compile-time (plus a lot easier to debug)

lesv · 2016-10-13T19:36:23Z

Sigh - meant to review this AM.

lesv

PTAL

lesv · 2016-10-13T19:38:02Z

appengine/firebase-tictactoe/README.md

+* Install [Apache Maven][maven] 3.0.5 or later
+* Create a project in the [Firebase Console][fb-console]
+* Install the [Google Cloud SDK][sdk]
+* For staging locally, you must supply credentials that would otherwise be


"staging locally" -> "local development". gcloud auth application-default login is preferred to GOOGLE_APPLICATION_CREDENTIALS

gcloud auth application-default login doesn't work (again). I'm getting permission-denied when using it to make firebase calls from the server. I think it also doesn't provide a value for appIdentity.getServiceAccountName(), since it's not a service account. And I think it also can't sign the jwt, since it's not actually an RSA cert.

I changed it from "local development" to "staging locally" because I was afraid "local development" would be confused with like, just coding it locally (and deploying it remotely). What about - "If using the dev appserver, ..."?

Ah - that makes sense - so explain that. (It's a firebase "feature")

lesv · 2016-10-13T19:39:30Z

appengine/firebase-tictactoe/README.md

+  Firebase to your web app' and replace the contents of the file
+  `src/main/webapp/WEB-INF/view/firebase_config.jspf` with that code snippet.
+* Edit
+  [`src/main/webapp/WEB-INF/appengine-web.xml`](src/main/webapp/WEB-INF/appengine-web.xml)


Really isn't required anymore, I typically use the string no-longer-required, the next Java SDK release will let us delete the line.

Ah - so it fails if the element isn't there, but then it ignores it. Yay.

lesv · 2016-10-13T19:41:13Z

appengine/firebase-tictactoe/pom.xml

+            <plugin>
+                <groupId>com.google.cloud.tools</groupId>
+                <artifactId>appengine-maven-plugin</artifactId>
+                <version>1.0.0</version>


Us a property variable here.

lesv · 2016-10-13T19:41:50Z

appengine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/DeleteServlet.java

+
+public class DeleteServlet extends HttpServlet {
+  @Override
+  public void doPost(HttpServletRequest req, HttpServletResponse resp)


DevRel is a bit more relaxed on this.

lesv · 2016-10-13T19:43:07Z

...ngine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/FirebaseChannel.java

+import java.util.HashMap;
+import java.util.Map;
+
+public class FirebaseChannel {


Some comments about this class? Why is it here? You might also want to include our // [START blah] tags for interesting parts.

lesv · 2016-10-13T19:44:22Z

...ngine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/FirebaseChannel.java

+    return instance;
+  }
+
+  private FirebaseChannel() {


JavaDoc or at least some comments -- we are trying to teach.

lesv · 2016-10-13T19:46:57Z

appengine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/Game.java

+    return message.toString();
+  }
+
+  //[START send_updates]


Some comments would be good, if you are expecting us to publish it.

lesv · 2016-10-13T19:48:01Z

appengine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/MoveServlet.java

+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+public class MoveServlet extends HttpServlet {


At least some comments, if not full JavaDoc

lesv · 2016-10-13T19:49:06Z

...gine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/TicTacToeServlet.java

+          thisUri.getScheme(), thisUri.getUserInfo(), thisUri.getHost(),
+          thisUri.getPort(), thisUri.getPath(), query, "");
+      return uriWithOptionalGameParam.toString();
+    } catch (URISyntaxException e) {


If we aren't bothering to do something with it, why catch it?

At the very least tell the user why they want to catch it.

Mm... because java won't compile it unless I do? :-) It's either that, or let it through and make all the callers deal with it...

You can mention that your method throws URISyntaxEception at the top and it should compile.

Unfortunately, it doesn't look like URISyntaxException is a RuntimeException, so all callers would have to deal with it :-/

lesv · 2016-10-13T19:51:39Z

...gine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/TicTacToeServlet.java

+      }
+      ofy.save().entity(game).now();
+    } else {
+      game = new Game(userId, null, "         ", true);


All those spaces seem wrong for some reason, seems pointless to have more than one, HTML will compress it, who needs that many?

And yes, I'm sure it came to you that way, so, I'm find if you just understand why that's necessary.

Haha :-) The spaces are a flat representation of the game board. ie there are nine blank spaces, to signify that each of the nine spaces of the tic-tac-toe board are empty and available to move to. As the game progresses, they'll be replaced by 'X' and 'O' characters.

Though you could mention that in a comment.

jerjou

Updated - PTAL

jerjou · 2016-10-13T19:30:54Z

...gine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/TicTacToeServlet.java

+    // 4. More general template values
+    req.setAttribute("game_key", gameKey);
+    req.setAttribute("me", userId);
+    req.setAttribute("channel_id", game.getChannelKey(userId));


I think "channel_id" still conveys the meaning fairly well. It's still a communication channel, even if it's not using the channel api per se.

I dunno - do you have a strong preference for another name?

jerjou · 2016-10-13T20:40:43Z

appengine/firebase-tictactoe/README.md

+* Install [Apache Maven][maven] 3.0.5 or later
+* Create a project in the [Firebase Console][fb-console]
+* Install the [Google Cloud SDK][sdk]
+* For staging locally, you must supply credentials that would otherwise be


gcloud auth application-default login doesn't work (again). I'm getting permission-denied when using it to make firebase calls from the server. I think it also doesn't provide a value for appIdentity.getServiceAccountName(), since it's not a service account. And I think it also can't sign the jwt, since it's not actually an RSA cert.

I changed it from "local development" to "staging locally" because I was afraid "local development" would be confused with like, just coding it locally (and deploying it remotely). What about - "If using the dev appserver, ..."?

jerjou · 2016-10-13T20:46:24Z

appengine/firebase-tictactoe/README.md

+  Firebase to your web app' and replace the contents of the file
+  `src/main/webapp/WEB-INF/view/firebase_config.jspf` with that code snippet.
+* Edit
+  [`src/main/webapp/WEB-INF/appengine-web.xml`](src/main/webapp/WEB-INF/appengine-web.xml)


Ah - so it fails if the element isn't there, but then it ignores it. Yay.

jerjou · 2016-10-13T21:02:51Z

...gine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/TicTacToeServlet.java

+          thisUri.getScheme(), thisUri.getUserInfo(), thisUri.getHost(),
+          thisUri.getPort(), thisUri.getPath(), query, "");
+      return uriWithOptionalGameParam.toString();
+    } catch (URISyntaxException e) {


Mm... because java won't compile it unless I do? :-) It's either that, or let it through and make all the callers deal with it...

jerjou · 2016-10-13T21:07:02Z

...gine/firebase-tictactoe/src/main/java/com/example/appengine/firetactoe/TicTacToeServlet.java

+      }
+      ofy.save().entity(game).now();
+    } else {
+      game = new Game(userId, null, "         ", true);


Haha :-) The spaces are a flat representation of the game board. ie there are nine blank spaces, to signify that each of the nine spaces of the tic-tac-toe board are empty and available to move to. As the game progresses, they'll be replaced by 'X' and 'O' characters.

lesv · 2016-10-14T17:30:13Z

LGTM

jerjou assigned lesv Oct 11, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2016

lesv suggested changes Oct 11, 2016

View reviewed changes

jerjou force-pushed the channel-api branch from bfbd314 to 187e8f7 Compare October 12, 2016 00:26

jerjou commented Oct 12, 2016

View reviewed changes

lesv reviewed Oct 12, 2016

View reviewed changes

elharo reviewed Oct 12, 2016

View reviewed changes

joaoandremartins reviewed Oct 12, 2016

View reviewed changes

jerjou force-pushed the channel-api branch from 187e8f7 to 99dc698 Compare October 13, 2016 02:38

lesv reviewed Oct 13, 2016

View reviewed changes

jerjou force-pushed the channel-api branch from 99dc698 to f38eb2c Compare October 13, 2016 21:07

jerjou commented Oct 13, 2016

View reviewed changes

jerjou force-pushed the channel-api branch 2 times, most recently from ce7de41 to 36c256b Compare October 13, 2016 21:43

Add GAE standard + firebase tictactoe sample

e9ed5e2

jerjou force-pushed the channel-api branch from 36c256b to e9ed5e2 Compare October 13, 2016 21:44

lesv approved these changes Oct 14, 2016

View reviewed changes

jerjou merged commit 6444d05 into master Oct 14, 2016

jerjou deleted the channel-api branch October 14, 2016 17:51

Shabirmean mentioned this pull request Nov 11, 2022

samples: migrate code from googleapis/java-contact-center-insights #7411

Merged

9 tasks

Sita04 mentioned this pull request Nov 11, 2022

migrate code from googleapis/java-webrisk #7415

Merged

9 tasks

Shabirmean mentioned this pull request Nov 16, 2022

samples: migrate code from googleapis/java-dialogflow-cx #7435

Merged

9 tasks

Shabirmean mentioned this pull request Nov 17, 2022

samples: migrate code from googleapis/java-automl #7444

Merged

9 tasks

Add GAE standard + firebase tictactoe sample #358

Add GAE standard + firebase tictactoe sample #358

Uh oh!

Conversation

jerjou commented Oct 11, 2016

Uh oh!

codecov-io commented Oct 11, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 48.19% (diff: 100%)

Uh oh!

lesv left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jerjou Oct 11, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jerjou Oct 11, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jerjou left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jerjou Oct 11, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jerjou Oct 11, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov-io commented Oct 11, 2016 •

edited

Loading

jerjou Oct 11, 2016 •

edited

Loading

jerjou Oct 11, 2016 •

edited

Loading

jerjou Oct 11, 2016 •

edited

Loading

jerjou Oct 11, 2016 •

edited

Loading

elharo Oct 12, 2016 •

edited

Loading