fix: fail step on non-zero exit code

[wilsonjord]

Currently, terraform errors for terraform fmt are not failing the build:
https://github.com/GeoNet/terraform-aws/actions/runs/22419354659/job/64913111658

Run terraform fmt -check -diff=true -recursive
╷
│ Error: Unclosed configuration block
│ 
│   on modules/ecs_docker_task_ng/main.tf line 851, in resource "aws_iam_role_policy" "ecs_taskprotection_policy":
│  851: resource "aws_iam_role_policy" "ecs_taskprotection_policy" {
│ 
│ There is no closing brace for this block before the end of the file. This
│ may be caused by incorrect brace nesting elsewhere in this file.
╵

The reason this failure still passed was due to the fact that the terraform setup action uses a wrapper by default - this wrapper captures stdout, stderr, and exitcode, and exposes those in outputs:

terraform_wrapper - (optional) Whether to install a wrapper to wrap subsequent calls of the terraform binary and expose its STDOUT, STDERR, and exit code as outputs named stdout, stderr, and exitcode respectively. Defaults to true.

As none of those outputs are captured / utilised in this workflow, simplest is to disable the wrapper, and have the normal cli fail -> non zero exit code -> build fails process.

[jajera]

@wilsonjord can you please share your last PR which silently exited?

[wilsonjord]

@jajera https://github.com/GeoNet/terraform-aws/pull/2092

[jajera]

terraform fmt does work like https://github.com/GeoNet/terraform-aws/actions/runs/22662055179/job/65684442857#step:6:40 but not consistently like in https://github.com/GeoNet/terraform-aws/pull/2092/checks#step:6:8.

[jajera]

lets give this a go.

[wilsonjord]

@jajera Just for extra context, I believe the key difference between the two is that in one case, terraform fmt was able to be successfully run, parsed valid files, and determined there was a genuine issue.

The other case, terraform fmt wasn't even able to be run, as it detected broken files, so couldn't perform it's task at all.