GPII-4231: JJ's rewrite of SystemSettingsHandler for Colour Vision merged up with master by amb26 · Pull Request #311 · GPII/windows

amb26 · 2020-04-08T13:02:12Z

No description provided.

…entation

…the native settingsHelper

…older

…uild is called for 'SettingsHelper'

… using visual studio 2015

…lean'

…ows-sdk-10 preventing sdk-8.1 corruption

…Helper' building

…ss on time

…waiting logic

…unction

…ayloads

…ore initial settings

…per function _SetValue

…acro

…ations for settingsHelperTests

…gsHelper executable

…ption

…orm 'pragma once' usage

… info

amb26 · 2020-04-24T08:25:59Z

ok to test

gpii-bot · 2020-04-24T10:31:08Z

CI job failed: https://ci.gpii.net/job/windows-tests/1344/

amb26 · 2020-04-24T11:47:48Z

Acceptance test hang again:

02:08:18.508:  Writing journal file to path C:\Users\vagrant\AppData\Local\Temp/gpii/journal-2020-04-24T090607.987Z.json
02:08:18.530:  UserLogonRequest completes successfully with the payload: User with GPII key os_win was successfully logged in.
Build was aborted
Aborted by unknown
Finished: ABORTED

amb26 · 2020-04-24T11:47:53Z

ok to test

gpii-bot · 2020-04-24T12:31:36Z

CI job failed: https://ci.gpii.net/job/windows-tests/1345/

amb26 · 2020-04-24T13:11:23Z

Run 1345: Worrying, massive failure to restore the value of most settings - screen resolution, narrator registry settings, onscreen keyboard, sound sentry, mouse settings, sticky keys, and touchpad. See gist at https://gist.github.com/amb26/485c08897742d8013af0ac66d7045617

amb26 · 2020-04-24T13:11:29Z

ok to test

gpii-bot · 2020-04-24T13:54:15Z

CI job failed: https://ci.gpii.net/job/windows-tests/1347/

amb26 · 2020-04-24T14:16:45Z

Unit test failure in process handling:

06:45:28.002:  Executing \\vboxsvr\vagrant\gpii\node_modules\processHandling\test\test-window.exe -window
06:45:28.788:  jq: FAIL: Module "gpii.tests.windows.processHandling" Test name "Testing closeProcessByName" - Message: Expected 3 assertions, but 2 were run
06:45:28.790:  jq: Source:     at Object.asyncTest (\\vboxsvr\vagrant\node_modules\infusion\tests\lib\qunit\js\qunit.js:406:9)
    at Object.<anonymous> (\\vboxsvr\vagrant\gpii\node_modules\processHandling\test\testProcessHandling.js:165:8)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Module.replacementCompile (\\vboxsvr\vagrant\node_modules\append-transform\index.js:58:13)
    at Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Object.<anonymous> (\\vboxsvr\vagrant\node_modules\append-transform\index.js:62:4)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (\\vboxsvr\vagrant\tests\UnitTests.js:24:1)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Module.replacementCompile (\\vboxsvr .... [output suppressed at 1024 chars - for more output, increase fluid.logObjectRenderChars]
06:45:28.794:  jq: Test concluded - Module "gpii.tests.windows.processHandling" Test name "Testing closeProcessByName": 2/3 passed - FAIL
06:45:28.918:  Executing C:\Users\vagrant\AppData\Local\Temp\gpii-process-handling-test.exe closeProcessByNameTest /T 30
06:45:28.934:  Exit code:5
06:45:29.686:  Process gpii-process-handling-test.exe will not close cleanly: No windows belong to the process
06:45:30.058:  jq: FAIL: Module "gpii.tests.windows.processHandling" Test name "Testing closeProcessByName (window-less process)" - Message: Expected 3 assertions, but 4 were run
06:45:30.058:  jq: Source:     at Object.asyncTest (\\vboxsvr\vagrant\node_modules\infusion\tests\lib\qunit\js\qunit.js:406:9)
    at Object.<anonymous> (\\vboxsvr\vagrant\gpii\node_modules\processHandling\test\testProcessHandling.js:201:8)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Module.replacementCompile (\\vboxsvr\vagrant\node_modules\append-transform\index.js:58:13)
    at Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Object.<anonymous> (\\vboxsvr\vagrant\node_modules\append-transform\index.js:62:4)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (\\vboxsvr\vagrant\tests\UnitTests.js:24:1)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Module.replacementCompile (\\vboxsvr .... [output suppressed at 1024 chars - for more output, increase fluid.logObjectRenderChars]
06:45:30.059:  jq: Test concluded - Module "gpii.tests.windows.processHandling" Test name "Testing closeProcessByName (window-less process)": 4/5 passed - FAIL

amb26 · 2020-04-24T14:16:53Z

ok to test

gpii-bot · 2020-04-24T14:58:56Z

CI job passed: https://ci.gpii.net/job/windows-tests/1348/

amb26 · 2020-04-24T15:27:50Z

ok to test

gpii-bot · 2020-04-24T16:09:31Z

CI job passed: https://ci.gpii.net/job/windows-tests/1349/

amb26 · 2020-04-24T16:18:52Z

ok to test

gpii-bot · 2020-04-24T16:59:53Z

CI job passed: https://ci.gpii.net/job/windows-tests/1350/

amb26 · 2020-04-24T22:21:14Z

ok to test

gpii-bot · 2020-04-24T23:04:33Z

CI job passed: https://ci.gpii.net/job/windows-tests/1351/

amb26 · 2020-04-24T23:05:10Z

ok to test

gpii-bot · 2020-04-24T23:45:10Z

CI job passed: https://ci.gpii.net/job/windows-tests/1352/

amb26 · 2020-04-24T23:53:26Z

ok to test

gpii-bot · 2020-04-25T00:34:05Z

CI job passed: https://ci.gpii.net/job/windows-tests/1353/

amb26 · 2020-04-26T09:40:57Z

ok to test

gpii-bot · 2020-04-26T10:25:07Z

CI job passed: https://ci.gpii.net/job/windows-tests/1354/

amb26 · 2020-04-26T11:23:47Z

ok to test

gpii-bot · 2020-04-26T12:04:37Z

CI job passed: https://ci.gpii.net/job/windows-tests/1355/

amb26 · 2020-04-26T21:30:52Z

ok to test

gpii-bot · 2020-04-26T22:17:02Z

CI job passed: https://ci.gpii.net/job/windows-tests/1356/

amb26 · 2020-04-27T10:29:15Z

ok to test

gpii-bot · 2020-04-27T11:08:29Z

CI job passed: https://ci.gpii.net/job/windows-tests/1357/

JavierJF added 30 commits November 15, 2019 10:04

GPII-4152: Replaced old-managed settingsHelper with new native implem…

0974bf3

…entation

GPII-4152: Added new development dependencies necessary for building …

66dd0ad

…the native settingsHelper

GPII-4152: Added new building steps for the native settingsHelper

54df327

GPII-4152: Added project config to place app binary in the root bin f…

ed4c99e

…older

GPII-4152: Changed executable name to match replaced solution

55ca835

GPII-4152: Modified the installed sdk version and changed the way msb…

879136d

…uild is called for 'SettingsHelper'

GPII-4152: Modified project files for being able to build the project…

9237c6f

… using visual studio 2015

GPII-4152: Removed unused variable

5480566

GPII-4152: Fixed warning with explicit conversion from 'bool' to 'boo…

0e22cff

…lean'

GPII-4152: Fixed non-returning payload readed from standard input

dde3b6d

GPII-4152: Uninstalled box windows-sdk-8.1 and reinstalled after wind…

1ee46a4

…ows-sdk-10 preventing sdk-8.1 corruption

GPII-4152: Added env variable selecting vstudio version for 'Settings…

d8a0e0f

…Helper' building

GPII-4152: Temporarly added more resources to VM to try to make CI pa…

e9508fe

…ss on time

GPII-4152: Reversed the VM resources to regular ones

7cd288b

GPII-4152: Refactored set method using helper function encapsulating …

e572ae7

…waiting logic

GPII-4152: Removed unnecessary legacy operations in 'handlePayload' f…

a5d1ac8

…unction

GPII-4231: Changed universal reference

2543fcc

GPII-4152: Added new checking get/set of required setting

02c78d0

GPII-4152: Added support for serializing and comparing string value p…

ada0636

…ayloads

GPII-4152: Added new tests for required setting and making tests rest…

f9ec64a

…ore initial settings

GPII-4152: Removed redundant checks

a27c8cc

GPII-4152: Fixed the access to internal dbSettigns and the member hel…

57e6893

…per function _SetValue

GPII-4152: Changed the comment style from special test in favour of m…

3cbae25

…acro

GPII-4152: Added multiprocessor compilation to other project configur…

95fd5fd

…ations for settingsHelperTests

GPII-4152: Added example payloads that can be used to test the settin…

e38914d

…gsHelper executable

GPII-4152: Added copyright headers in project files with brief descri…

769e8a3

…ption

Merge branch 'GPII-4152' into GPII-4231

14b2417

GPII-4152: Added forgotten empty-line at the end of file

5d6913b

GPII-4152: Removed included guards for header files in favour of unif…

85aa6cd

…orm 'pragma once' usage

GPII-4152: Changed comment style to reflect the fact that is research…

b1a7b80

… info

amb26 merged commit 2e04c69 into GPII:master Apr 27, 2020

Comments

Conversation

amb26 commented Apr 8, 2020

Uh oh!

amb26 commented Apr 24, 2020

Uh oh!

gpii-bot commented Apr 24, 2020

Uh oh!

amb26 commented Apr 24, 2020

Uh oh!

amb26 commented Apr 24, 2020

Uh oh!

gpii-bot commented Apr 24, 2020

Uh oh!

amb26 commented Apr 24, 2020

Uh oh!

amb26 commented Apr 24, 2020

Uh oh!

gpii-bot commented Apr 24, 2020

Uh oh!

amb26 commented Apr 24, 2020

Uh oh!

amb26 commented Apr 24, 2020

Uh oh!

gpii-bot commented Apr 24, 2020

Uh oh!

amb26 commented Apr 24, 2020

Uh oh!

gpii-bot commented Apr 24, 2020

Uh oh!

amb26 commented Apr 24, 2020

Uh oh!

gpii-bot commented Apr 24, 2020

Uh oh!

amb26 commented Apr 24, 2020

Uh oh!

gpii-bot commented Apr 24, 2020

Uh oh!

amb26 commented Apr 24, 2020

Uh oh!

gpii-bot commented Apr 24, 2020

Uh oh!

amb26 commented Apr 24, 2020

Uh oh!

gpii-bot commented Apr 25, 2020

Uh oh!

amb26 commented Apr 26, 2020

Uh oh!

gpii-bot commented Apr 26, 2020

Uh oh!

amb26 commented Apr 26, 2020

Uh oh!

gpii-bot commented Apr 26, 2020

Uh oh!

amb26 commented Apr 26, 2020

Uh oh!

gpii-bot commented Apr 26, 2020

Uh oh!

amb26 commented Apr 27, 2020

Uh oh!

gpii-bot commented Apr 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants