Set expected file mode in test to 644

[McSinyx]

For real files, git only distinguish between executable or not, and the mode of a checked-out file is either 644 or 755.

[McSinyx]

Gentle ping!

[GJDuck]

This seems to depend on the system, and the patch will fail when I try it. Perhaps the mode can be set explicitly in the Makefile?

PS: the entire regtest suite will pass on my system, but can fail on other systems. This should be fixed eventually.

[McSinyx]

Perhaps the mode can be set explicitly in the Makefile?

Ideally, yes, then reverted to the original mode (or to be run in some isolated environment).

Does the suite in a fresh checkout pass on your system though? From the Git index format documentation:

9-bit unix permission. Only 0755 and 0644 are valid for regular files.
Symbolic links and gitlinks have value 0 in this field.

Git wouldn't mandate these two modes for existing file (e.g. mode change from 644 to 664 is ignored), but new files would be created with mode 755 or 644.

[McSinyx]

May I have this merged? If the documentation is not convincing enough, here are the modes of added files in a formatted patch.

[GJDuck]

The Makefile now sets the mode explicitly, so the test should now pass for any system.

[McSinyx]

Thanks!