Open
Conversation
Contributor
|
Looks super clean and elegant. Nice job. Update your PR so that your solution is added to the top of the existing solution. And write your name and/or GitHub profile in the comments above your solution to give yourself credit. |
Author
|
Yes sir. It's my first PR and I'm not that familiar with GitHub yet. Please
let me know if I did it correctly. Or if there's anything else I missed
about trying doing a PR, commit, etc.
Hope the new job is treating you well, let's chat soon.
Matt
…On Tue, Feb 14, 2017 at 12:05 AM, Stephen Mayeux ***@***.***> wrote:
Looks super clean and elegant. Nice job. Update your PR so that your
solution is added to the top of the existing solution. And write your name
and/or GitHub profile in the comments above your solution to give yourself
credit.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APQUHPVL92OvYuaFYILQm7q2ejWWQZkKks5rcHFXgaJpZM4L-tmd>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been working on all of the basic algorithm challenges again. Started understanding more and thought this was much shorter than my previous answer. Let me know what you think.