fix FP16 bug of track_id annotation, ReID related#184
Merged
ifzhang merged 1 commit intoFoundationVision:mainfrom Apr 27, 2022
Merged
fix FP16 bug of track_id annotation, ReID related#184ifzhang merged 1 commit intoFoundationVision:mainfrom
ifzhang merged 1 commit intoFoundationVision:mainfrom
Conversation
|
Do you mean that we'd better train with torch.float32? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When training with FP16, annotations of bbox and track_id named as
targetswill be set to torch.float16 from torch.float32.But actually, track_id annotations will lose their precision during this procedure, resulting wrong labels for ReID module.
So with the wrong labels, ReID module can not be trained normally, getting extreme low mAP and top-k ranking in person search benchmarks.
After fixing this bug, we can get normal results.