Skip to content

Cleanup @SupressWarnings annotation #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paodb merged 4 commits into from
Jul 19, 2023
Merged

Cleanup @SupressWarnings annotation #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26823a9
test: fix LicenseCleanup test case
javier-godoy Jul 19, 2023
bc3f9d5
test: fix parameter handling int SourceCodeViewerView
javier-godoy Jul 19, 2023
7badb79
fix: fix typo in code-viewer __compare
javier-godoy Jul 19, 2023
3f7ccd7
feat: cleanup @SupressWarnings annotation
javier-godoy Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/resources/META-INF/resources/frontend/code-viewer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,7 @@ pre[class*="language-"] {
&& !line.startsWith('@Route')
&& !line.startsWith('@PageTitle')
&& !line.startsWith('@DemoSource')
&& !line.startsWith('@SuppressWarnings')
&& !line.startsWith('package ')
&& line != 'import com.vaadin.flow.router.PageTitle;'
&& line != 'import com.vaadin.flow.router.Route;'
Expand Down Expand Up @@ -354,7 +355,7 @@ pre[class*="language-"] {
if (ai>bi) return +1;
}
if (aa.length<bb.length) return -1;
if (aa.length<bb.length) return +1;
if (aa.length>bb.length) return +1;
return 0;
}

Expand Down
7 changes: 2 additions & 5 deletions src/test/java/com/flowingcode/vaadin/addons/demo/it/SourceCodeViewerView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,11 @@ public class SourceCodeViewerView extends Div implements HasUrlParameter<String>
public void setParameter(BeforeEvent event, @OptionalParameter String parameter) {
Map<String, String> properties = null;
if (parameter != null) {
String[] ss = parameter.split(";");

properties = new HashMap<>();
for (int i = 1; i < ss.length; i++) {
String param[] = ss[i].split("=");
for (String s : parameter.split(";")) {
String param[] = s.split("=");
properties.put(param[0], param[1]);
}

if (properties.isEmpty()) {
properties = null;
}
Expand Down
1 change: 1 addition & 0 deletions src/test/resources/com/flowingcode/vaadin/addons/demo/it/AnnotationCleanup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
@Route
@PageTitle("pagetitle")
@DemoSource
@SuppressWarnings
class MyClass {

}
2 changes: 1 addition & 1 deletion src/test/resources/com/flowingcode/vaadin/addons/demo/it/LicenseCleanup.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//Copyright (C) 2021 - 2023 Flowing Code
//Copyright (C) 2020 - 2023 Flowing Code
//Licensed under the Apache License, Version 2.0

class MyClass {
Expand Down