Conversation
c9162c5 to
c4a6802
Compare
|
lgtm! |
gpratte-flare
approved these changes
May 15, 2025
c4a6802 to
64a94c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scroll_eventswhich includes the logic to call an an events api with all uids returned from a feed api.I don't want to expose the limiter arg as public right now because I think in the future this can just be replaced by reading ratelimit headers from our API. So, for now, I focus on supporting this simple common use case. We can revisit when we get more feedback and after we have implemented ratelimit headers.
This allow us to replace this example by: