Rebased version of reverted #109#205
Open
greimel wants to merge 5 commits intoFixedEffects:masterfrom
Open
Conversation
Contributor
Author
|
I've gotten rid of the excess allocations. |
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
- Coverage 96.08% 95.45% -0.64%
==========================================
Files 8 8
Lines 588 638 +50
==========================================
+ Hits 565 609 +44
- Misses 23 29 +6
Continue to review full report at Codecov.
|
Contributor
|
Can this be closed as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My initial PR #109 was merged and then reverted
by @eloualiche. I benchmarked this PR vs master (using the middle regression model in
benchmarks/benchmarks.jlIs this difference significant enough to prevent this feature?