Skip to content

Mimetic spectral elements#5

Merged
chrisrichardson merged 3 commits intoFEniCS:masterfrom
firedrakeproject:mse
Sep 10, 2019
Merged

Mimetic spectral elements#5
chrisrichardson merged 3 commits intoFEniCS:masterfrom
firedrakeproject:mse

Conversation

@celdred
Copy link
Copy Markdown
Contributor

@celdred celdred commented Jun 28, 2019

This pull request adds mimetic spectral elements (described at https://www.sciencedirect.com/science/article/pii/S0021999113006414 and https://arxiv.org/abs/1111.4304), both the primal and dual complexes. This is done by adding the relevant 1D H1 element for the dual complex: Extended Gauss Legendre (EGL); and the L2 edge elements associated with GLL and EGL. These are non-Ciarlet finite elements that use a basis that histopolates (http://people.math.sfu.ca/~nrobidou/public_html/prints/histogram/histogram.pdf) rather than interpolates. The nD deRham complex on hypercubes is then accessible using the variant keyword (either “mse” or “dualmse”) with the relevant elements (DQ, Q, RTCF, etc.).

It also requires correct (integral-preserving) L2 pullbacks from #4.

@miklos1
Copy link
Copy Markdown
Contributor

miklos1 commented Aug 26, 2019

Okay, so this pull request is not very useful here. FIAT and UFL pull requests should be filed against upstream to be merged: https://bitbucket.org/fenics-project/ufl

If you want to receive code review from the Firedrake team before filing the pull request upstream, then please file the pull request against firedrakeproject:master and not FEniCS:master (as is the case with this PR). Since this GitHub mirror is quite out of date, the diff shown for this PR is practically unreadable.

@wence-
Copy link
Copy Markdown
Collaborator

wence- commented Sep 9, 2019

I will squash and rebase this is that ufl is being developed here rather than bitbucket.

@wence-
Copy link
Copy Markdown
Collaborator

wence- commented Sep 9, 2019

I think this is now ready for review. As @celdred says, it registers a bunch of new elements.

[Aside, should we think of/advocate a way that third party "clients" of UFL can register new elements without having to put them all in here?]

@chrisrichardson chrisrichardson merged commit 9224204 into FEniCS:master Sep 10, 2019
@wence- wence- deleted the mse branch August 20, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants