Use node timers instead of minetest.after()#6
Open
doxygen-spammer wants to merge 4 commits intoExtex101:masterfrom
Open
Use node timers instead of minetest.after()#6doxygen-spammer wants to merge 4 commits intoExtex101:masterfrom
doxygen-spammer wants to merge 4 commits intoExtex101:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the amount of necessary map block updates.
Before this, temporary light sources were removed and readded in every step, which caused a no-op block update everytime. After this, light_beam() just restarts the node timer, so no nodes actually change when you don’t move the light beam.
This can be observed, after pressing F5 twice, in the client_received_packets graph (yellow).
Additionally, this makes the light beam work over the full active_block_range (when you don’t move), because temporary light sources are static then, so the server considers a block update appropriate.
Unfortunately, this doesn’t work with water. I think, the glow nodes are flooded in a way different to e. g. torches, where on_flood() is not executed.
I suggest to sqash-merge this.