Fix ellipsis issues for Text numberOfLines={1}#5
Fix ellipsis issues for Text numberOfLines={1}#5roryabraham merged 3 commits intoExpensify:masterfrom
numberOfLines={1}#5Conversation
luacmartins
left a comment
There was a problem hiding this comment.
Changes seem ok, but can you remind me why we don't just remove whitespace: no-wrap from here?
|
Because we want the text to be clipped with an ellipsis. Ellipsis won't show on the web until text wraps. And removing this line will not fix the issues that we are facing. After this change, we won't need that style. It would be automatically applied. And we can remove that line https://github.com/Expensify/App/blob/f8e48cdf877c9dc9576a429ccb2885969b82e93c/src/styles/styles.js#L1103. |
|
I'm not too sure if this is the best way to solve this issue. @roryabraham could you please take a look? |
|
You will get more details on the linked orginal PR and details behind reverting and the fix. |
|
Taking a look at this now |
roryabraham
left a comment
There was a problem hiding this comment.
Honestly, I'm not completely sure about this either – I'm sure necolas will have a more informed opinion if/when they eventually review the upstream PR. But looking at the SO @parasharrajat linked this seems like a viable solution to both the original issue solved by the commit you're reverting and the new issues we're seeing now.
|
Thanks for the input @roryabraham! |
PR for Expensify/App#7206
Original PR necolas#2193
cc: @roryabraham