Fix inverted flatlist #2
Merged
thienlnam merged 1 commit intoExpensify:masterfrom Nov 3, 2021
azimgd:fix-reverted-flatlist-signed
Merged
Fix inverted flatlist #2thienlnam merged 1 commit intoExpensify:masterfrom azimgd:fix-reverted-flatlist-signed
thienlnam merged 1 commit intoExpensify:masterfrom
azimgd:fix-reverted-flatlist-signed
Conversation
…orm: translate] css hack and instead adding flatlist array items in reverse order [unshift instead of push]; It also reverses ScrollView event response received from browser [e.nativeEvent.configOffset *= -1];
This was referenced Nov 3, 2021
Closed
thienlnam
approved these changes
Nov 3, 2021
Merged
59 tasks
6 tasks
Open
6 tasks
53 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected Result:
<FlatList inverted={true} />that when you highlight lines of text, including across multiple messages, that the text is highlighted in order from top to bottom or bottom to top.Flatlist, that it shows up in the correct order.Actual Result:
This has been reviewed and tested by multiple developers. Some references are:
Implementation
I have removed flatlist inversion (by inverted=true prop) which used [transform: translate] css hack and instead adding flatlist array items in reverse order [unshift instead of push]; It also reverses ScrollView event response received from browser [e.nativeEvent.configOffset *= -1];
Sidenote
I was not able to fix this issue by applying this code directly in React Native repo. The reason is that RN column-reverse won't anchor scroll position to the bottom on Mobile device as it does on Web
facebook/yoga#866 (comment)