Skip to content

Disable autocomplete when selecting block #44113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srikarparsi merged 2 commits into from
Jun 20, 2024
Merged

Disable autocomplete when selecting block #44113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e184c6
Disable mention suggestion box if selecting text
aldo-expensify Jun 20, 2024
f431cb7
Disable emoji suggestion box if selecting text
aldo-expensify Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/pages/home/report/ReportActionCompose/SuggestionEmoji.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ function SuggestionEmoji(
* Calculates and cares about the content of an Emoji Suggester
*/
const calculateEmojiSuggestion = useCallback(
(selectionEnd?: number) => {
if (!selectionEnd || shouldBlockCalc.current || !value) {
(selectionStart?: number, selectionEnd?: number) => {
if (selectionStart !== selectionEnd || !selectionEnd || shouldBlockCalc.current || !value) {
shouldBlockCalc.current = false;
resetSuggestions();
return;
Expand Down Expand Up @@ -181,7 +181,7 @@ function SuggestionEmoji(
if (!isComposerFocused) {
return;
}
calculateEmojiSuggestion(selection.end);
calculateEmojiSuggestion(selection.start, selection.end);
}, [selection, calculateEmojiSuggestion, isComposerFocused]);

const setShouldBlockSuggestionCalc = useCallback(
Expand Down
6 changes: 3 additions & 3 deletions src/pages/home/report/ReportActionCompose/SuggestionMention.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,8 @@ function SuggestionMention(
);

const calculateMentionSuggestion = useCallback(
(selectionEnd?: number) => {
if (!selectionEnd || shouldBlockCalc.current || selectionEnd < 1 || !isComposerFocused) {
(selectionStart?: number, selectionEnd?: number) => {
if (selectionEnd !== selectionStart || !selectionEnd || shouldBlockCalc.current || selectionEnd < 1 || !isComposerFocused) {
shouldBlockCalc.current = false;
resetSuggestions();
return;
Expand Down Expand Up @@ -384,7 +384,7 @@ function SuggestionMention(
);

useEffect(() => {
calculateMentionSuggestion(selection.end);
calculateMentionSuggestion(selection.start, selection.end);
}, [selection, calculateMentionSuggestion]);

useEffect(() => {
Expand Down