Дополнение и исправление английских вариантов лексем #1533

Bayselonarrend · 2025-04-23T18:20:00Z

Поправил/дописал английские варианты в ContextMethod-ы, ContextClass-ы, EnumerationType-ы и пр. где ловил ошибки или видел пропущенные переводы. Надеюсь, я правильно понял, как это работает)

Summary by CodeRabbit

New Features
- Added English aliases for all public methods and enum values previously available only in Russian, improving accessibility for English-speaking users.
- Updated method and enum annotations to support both Russian and English identifiers across binary data operations, console functions, and template types.
- Deprecated the "ProgramDirectory" alias in favor of "BinDir" for program directory access.
Style
- Enhanced bilingual support throughout the user interface for method and enum names.

coderabbitai · 2025-04-23T18:20:06Z

Walkthrough

This change introduces English aliases to various context methods and enum values across several classes, supplementing the existing Russian identifiers. The modifications are limited to attributes and annotations, providing bilingual support for method and enum access without altering any underlying logic or control flow.

Changes

File(s)	Change Summary
src/OneScript.StandardLibrary/Binary/GlobalBinaryData.cs	Added English aliases to all `[ContextMethod]` attributes, enabling bilingual method access.
src/OneScript.StandardLibrary/Binary/MemoryStreamContext.cs	Added English alias "CloseAndGetBinaryData" to an existing context method attribute.
src/OneScript.StandardLibrary/Binary/StreamEnums.cs	Added English aliases to all `EnumValue` attributes in `FileOpenModeEnum`, `FileAccessEnum`, and `StreamPositionEnum`.
src/OneScript.StandardLibrary/StringOperations.cs	Updated `SearchDirection` enum values to include English aliases in their `EnumValue` attributes.
src/OneScript.StandardLibrary/Text/ConsoleContext.cs	Added English alias "Beep" to the `[ContextMethod]` attribute of the `Beep` method.
src/ScriptEngine.HostedScript/SystemGlobalContext.cs	Changed `[ContextMethod]` attributes for `ProgramDirectory()`, marking English alias as deprecated and renaming the second alias to "BinDir".
src/ScriptEngine.HostedScript/TemplateStorage.cs	Added English aliases to `EnumValue` attributes for `TemplateKind` enum values.

Possibly related PRs

EvilBeaver/OneScript#1466: Modifies the ContextMethodAttribute constructor and logic to better handle and retrieve method aliases, directly relating to the addition of English aliases in this PR.

Poem

In a meadow of code where languages meet,
Russian and English now share every seat.
Methods and enums, once shy and alone,
Now speak in two tongues, their meanings well known.
Bilingual bunnies, we hop and we cheer—
For code that says "hello" and "привет" loud and clear!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fd4b3cd and e134a35.

📒 Files selected for processing (1)

src/OneScript.StandardLibrary/Binary/StreamEnums.cs (1 hunks)

✅ Files skipped from review due to trivial changes (1)

src/OneScript.StandardLibrary/Binary/StreamEnums.cs

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

EvilBeaver · 2025-04-23T20:01:55Z

Если я не ошибаюсь, когда синоним не указан, он берется из имени метода. Т.е. если имя C# метода совпадает с английским названием в языке - то синоним указывать не обязательно.

Это, конечно, может не работать, но в этих классах синонимы пропущены намеренно.

Bayselonarrend · 2025-04-24T03:33:21Z

Если я не ошибаюсь, когда синоним не указан, он берется из имени метода. Т.е. если имя C# метода совпадает с английским названием в языке - то синоним указывать не обязательно.

Это, конечно, может не работать, но в этих классах синонимы пропущены намеренно.

Тогда вопрос только в 'КаталогПрограммы' и 'ПозицияВПотоке'

EvilBeaver · 2025-04-30T08:26:08Z

src/OneScript.StandardLibrary/Binary/StreamEnums.cs

    }

-    [EnumerationType("ПозицияВПотоке", "StreamPosition")]
+    [ContextMethod("StreamPosition", IsDeprecated = true)]


Зачем атрибут ContextMethod на енуме?

Ага, проглядел. А у EnumerationType есть возможность установить IsDeprecated = true?

По-моему нет. Но, очевидно, он нужен и на енуме и на классе

Просто добавить public bool IsDeprecated { get; set; } недостаточно будет, да?

Нет, ведь нужна будет еще ответная часть, которая будет обрабатывать это свойство.

EvilBeaver · 2025-05-05T14:50:46Z

@Bayselonarrend там не собирается билд, исправь, пожалуйста:

 D:\jenkins\workspace\1Script_PR\src\OneScript.StandardLibrary\Binary\StreamEnums.cs(40,40): error CS0246: Не удалось найти тип или имя пространства имен "IsDeprecated" (возможно, отсутствует директива using или ссылка на сборку). [D:\jenkins\workspace\1Script_PR\src\OneScript.StandardLibrary\OneScript.StandardLibrary.csproj]

https://build.oscript.io/job/1Script/view/change-requests/job/PR-1533/6/

Bayselonarrend · 2025-05-05T14:55:04Z

@EvilBeaver он не собирается, потому что я поставил EnumerationType с IsDepricated, а такого атрибута там нет. Не допилил по последнему комменту, что мы обсуждали

Bayselonarrend · 2025-05-05T16:37:36Z

Ну, оно не падает, но, как я понял, ничего и не делает. У меня знания шарпа мягко говоря ограниченные, не знаю что дальше. Наверное тут надо что-то добавить

И вероятно в Machine.Contexts.EnumerationContext. Но без подсказки могу только фигни какой-нибудь наделать

Bayselonarrend · 2025-05-05T17:06:56Z

Ну, оно не падает

Или падает. Что-то я ничего не понял

src/OneScript.Core/Contexts/Enums/EnumerationTypeAttribute.cs

This reverts commit fd4b3cd. Revert "Поле IsDeprecated в EnumerationType" This reverts commit 721eae1.

Bayselonarrend · 2025-05-28T07:42:22Z

@EvilBeaver вроде так

Дополнение и исправление английских вариантов лексем

56f7630

EvilBeaver requested changes Apr 30, 2025

View reviewed changes

Update StreamEnums.cs

608af9a

Bayselonarrend added 2 commits May 5, 2025 19:21

Поле IsDeprecated в EnumerationType

721eae1

AllowMultiple = true для EnumerationTypeAttribute

fd4b3cd

EvilBeaver reviewed May 12, 2025

View reviewed changes

src/OneScript.Core/Contexts/Enums/EnumerationTypeAttribute.cs Outdated Show resolved Hide resolved

Bayselonarrend added 2 commits May 28, 2025 10:24

Revert for two last changes

64c577c

This reverts commit fd4b3cd. Revert "Поле IsDeprecated в EnumerationType" This reverts commit 721eae1.

Возвращен оригинальный EnumerationType для ПозицияВПотоке

e134a35

Bayselonarrend mentioned this pull request May 28, 2025

Сделать английский вариант перечисления StreamPosition deprecated в пользу PositionInStream #1544

Closed

EvilBeaver approved these changes May 28, 2025

View reviewed changes

EvilBeaver merged commit bd084c3 into EvilBeaver:develop May 28, 2025
2 checks passed

Дополнение и исправление английских вариантов лексем #1533

Дополнение и исправление английских вариантов лексем #1533

Uh oh!

Conversation

Bayselonarrend commented Apr 23, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

EvilBeaver commented Apr 23, 2025

Uh oh!

Bayselonarrend commented Apr 24, 2025

Uh oh!

EvilBeaver Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

Bayselonarrend Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

EvilBeaver Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

Bayselonarrend Apr 30, 2025 • edited by EvilBeaver Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EvilBeaver commented May 5, 2025

Uh oh!

Bayselonarrend commented May 5, 2025

Uh oh!

Bayselonarrend commented May 5, 2025

Uh oh!

Bayselonarrend commented May 5, 2025

Uh oh!

Uh oh!

Bayselonarrend commented May 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Bayselonarrend commented Apr 23, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

Bayselonarrend Apr 30, 2025 •

edited by EvilBeaver

Loading