Add Geometry::estimateMemorySize() API

[mbasmanova]

I'm using ESRI Geometry API to provide geospatial query support in Presto ( https://prestodb.io/ ) and I need to calculate how much memory individual Geometry objects occupy. I'm using ClassLayout.parseClass to compute the base size of an object and then add on sizes of arrays, lists, etc. I need to be able to write this code:

private static final int MULTI_POINT_IMPL_INSTANCE_SIZE = ClassLayout.parseClass(MultiPointImpl.class).instanceSize();
private static final int MULTI_PATH_IMPL_INSTANCE_SIZE = ClassLayout.parseClass(MultiPathImpl.class).instanceSize();

(see https://github.com/prestodb/presto/pull/9474/files#diff-ac9e6026ae8bd12a435b09b61a5cc0fa)

But I can't because MultiPointImpl and MultiPathImpl classes are package private.

Would it be possible to make them public?

[stolstov]

If are working on this, would you be willing to add an abstract method to the Geometry class and other classes as needed called estimateMemorySize() that returns the size of the geometry instance in memory?

[stolstov]

      /**
      * Calculates approximate size of the structure in memory including all the data it holds.
      * @return size in bytes.
      */

[mbasmanova]

@stolstov Sergey, thanks for a quick response. Absolutely, I'd be happy to work on a PR to add estimateMemorySize() to the Geometry objects. Is there anything I should be aware of/read about before starting?

[stolstov]

@mbasmanova That would be great if you could add those methods. Please, use same formatting as we do, and read CONTRIBUTING.md (which is basically a link to this https://github.com/esri/contributing) for the legal info.

[mbasmanova]

@stolstov Sergey, PR #157 adds the new API. Would you take a look?

[stolstov]

@alocke Could you verify this?

[alocke]

Yes, I will.

[mbasmanova]

@alocke Annette, I'd like to use the new API in Presto https://prestodb.io/ . Do you have an idea of when a new release might be available?