Fix bug in SMT translation (abstraction of non-translatable constructions) #782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions) When abstracting out a construction that is not translatable into SMT, make the abstraction symbol depends on the local variables. If not, the translation is unsound by making the translated constructions a constant. For example, the following (where G will be abtracted): ``` fun x => G x ``` is translated into ``` fun x => fresh-constant ```
Member
Author
|
There is still an issue here: translations are cached globally and we insert terms that depend on the local context. This might lead to issues. |
strub
changed the title
strub
changed the title
bgregoir
approved these changes
May 26, 2025
oskgo
approved these changes
May 26, 2025
Contributor
oskgo
left a comment
oskgo
left a comment
There was a problem hiding this comment.
My larger example now fails as it should. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When abstracting out a construction that is not translatable into SMT, make the abstraction symbol depends on the local variables.
If not, the translation is unsound by making the translated constructions a constant. For example, the following (where G will be abtracted):
is translated into