Skip to content

Conversation

@oskgo
Copy link
Contributor

@oskgo oskgo commented Mar 4, 2025

Fixes #732

@oskgo
Copy link
Contributor Author

oskgo commented Mar 4, 2025

I'm not surprised that there's third party breakage here. This is a breaking change to a prelude theory.

How do I proceed? @strub?

@fdupress
Copy link
Member

fdupress commented Mar 4, 2025

Ping the maintainer, which we really should add to the config.

Fortunately, I'm the maintainer here. Will fix when I have some time.

@fdupress
Copy link
Member

fdupress commented Mar 5, 2025

So the fix, as expected, is not a valid proof in current main. We have two options:

  1. Stage the fix across two releases: first add the new lemma names, allowing smooth proof fixes; then change the lemma statements for the old lemma names;
  2. Ship it and issue a clear warning that this is coming, and how to fix it, to the Formosa meeting and via our other communication channels (including release notes).

As you know, Matthias and I put some work into figuring out how to enable 2 safely, so I'm completely fine with 2. But we have users whose proofs are not in the external CI.

Pierre-Yves @strub, thoughts? (And those thoughts should become policy at some point.)
Note also that the situation here is slightly different from #727:

This policy discussion should probably be moved off this issue.

@oskgo oskgo merged commit cd3ed71 into EasyCrypt:main Mar 7, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

negbLR and negbRL incorrect due to precedence

3 participants