-
Notifications
You must be signed in to change notification settings - Fork 58
remove alt-ergo from EasyCrypt TCB #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There are three theories I expect to still fail:
They all have two things in common: @bgregoir and a reading level beyond my Friday afternoon capabilities. Benjamin, if you could attempt to make those three theories work without alt-ergo, that would be very kind. |
714b16c to
a59a221
Compare
deb87b9 to
7ddbf6d
Compare
|
All stdlib should now be going through. I expect failures in the examples; which I'll tackle next. Failures in the external CI should not be expected: they bring their own |
03aa4ed to
ca29c89
Compare
|
I’ve pushed two commits that are relevant to this PR in an other branch: vbgl@d89de85 They fix the proofs of the examples without alt-ergo. |
|
Thanks, I'm not at work today, but if @strub or @Cameron-Low are able to cherry-pick those over to check CI, that would be grand. @vbgl, tell Benjamin he owes you a bunch for those proofs. |
ca29c89 to
e82cf2a
Compare
|
@fdupress I let you do the final cleaning & squashing. But everything seems OK now. |
strub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the added FIXME: cleanup
e094036 to
bf98a88
Compare
|
Cleaned up, squashed, and expanded a bit on the commit message. — Please check, @strub. |
bf98a88 to
b4ace84
Compare
This makes stdlib and examples go through without alt-ergo, and removes that prover from the expected set of provers for EC CI. This makes EasyCrypt more cleanly usable in commercial and non-free contexts. Our docker images still contain alt-ergo versions, which are available for proofs in external CI and individual proofs, upon a user's (hopefully informed) choice. Anyone wanting to transition their proofs away from alt-ergo should expect proofs that use SMT to solve goals that require either instantiation of existentials or case analysis on inductively-typed values to fail after removing alt-ergo.
b4ace84 to
e0abde9
Compare
This makes stdlib and examples go through without alt-ergo, and removes
that prover from the expected set of provers for EC CI.
This makes EasyCrypt more cleanly usable in commercial and non-free
contexts. Our docker images still contain alt-ergo versions, which are
available for proofs in external CI and individual proofs, upon a user's
(hopefully informed) choice.
Anyone wanting to transition their proofs away from alt-ergo should
expect proofs that use SMT to solve goals that require either
instantiation of existentials or case analysis on inductively-typed
values to fail after removing alt-ergo.