Extend clear tactic to allow clearing *all* unused items in the context recursively
#713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
As a first thing: it is probably best to add a unit test for this. There are a few examples in the |
oskgo
changed the title
clear * tactic to clear all unused items in the context recursivelyclear tactic to allow clearing *all* unused items in the context recursively
Contributor
Author
|
I've made the syntax change and feature additions as requested, and also added a test. |
Cameron-Low
requested changes
Feb 17, 2025
Contributor
Cameron-Low
left a comment
Cameron-Low
left a comment
There was a problem hiding this comment.
Just a few nits on style, otherwise looks good to me.
Cameron-Low
approved these changes
Feb 17, 2025
Contributor
Cameron-Low
left a comment
Cameron-Low
left a comment
There was a problem hiding this comment.
all good from me. @strub anything you want to add?
strub
reviewed
Feb 19, 2025
Member
|
When you are done, could you squash your commits into one? |
add exclude filters and test
Contributor
Author
|
All done and squashed |
Member
|
We can flag this as fixing #716 when merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was requested at the retreat.
Please have patience with the review. This is literally the first OCaml code I've ever written.