This repository was archived by the owner on Nov 6, 2023. It is now read-only.
[Rasende.dk] New ruleset #3732
Merged
[Rasende.dk] New ruleset #3732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Doesn't this need more test urls since it contains a rule lgtm |
Contributor
Author
|
Thanks for all the reviews. And good question; I never looked into the details of the test URL calculation myself; it looks like two tests would be needed, so maybe we're just happy because those two tests come from the target hosts. It's worth looking into, though, as it seems (from #3633 and #3726) that something is not quite right. |
Contributor
|
Gonna merge this, but we definitely need to look into ruleset testing a big more in those other issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.