Skip to content

Workaround for LMOD only allowing a single hook to be registered, which made our first hook unused #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocaisa merged 8 commits into from
Mar 7, 2024
Merged

Workaround for LMOD only allowing a single hook to be registered, which made our first hook unused #490

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
efbeb56
Use LMOD_CONFIG_DIR instead of LMOD_RC to allow user overrides of wha…
Mar 4, 2024
590cabd
Combine functions into a single function, before registering this as …
Mar 5, 2024
0de249e
Look for site-specific lmodrc file in host_injections. If present, se…
Mar 5, 2024
c1840dd
Next the local lmodrc within the versioned directory, e.g. /cvmfs/sof…
Mar 6, 2024
df4140a
Update init/eessi_environment_variables
ocaisa Mar 6, 2024
78e582b
Update init/eessi_environment_variables
ocaisa Mar 6, 2024
77c9723
Update init/eessi_environment_variables
ocaisa Mar 6, 2024
e33938f
Revert changes in eessi_environment_variables. Limit this PR to the b…
Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions create_lmodrc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
return content
end

local function cuda_enabled_load_hook(t)
local function eessi_cuda_enabled_load_hook(t)
local frameStk = require("FrameStk"):singleton()
local mt = frameStk:mt()
local simpleName = string.match(t.modFullName, "(.-)/")
Expand Down Expand Up @@ -94,7 +94,7 @@
end
end

local function openmpi_load_hook(t)
local function eessi_openmpi_load_hook(t)
-- disable smcuda BTL when loading OpenMPI module for aarch64/neoverse_v1,
-- to work around hang/crash due to bug in OpenMPI;
-- see https://gitlab.com/eessi/support/-/issues/41
Expand All @@ -114,8 +114,15 @@
end
end

hook.register("load", cuda_enabled_load_hook)
hook.register("load", openmpi_load_hook)
-- Combine both functions into a single one, as we can only register one function as load hook in lmod
-- Also: make it non-local, so it can be imported and extended by other lmodrc files if needed
function eessi_load_hook(t)
eessi_cuda_enabled_load_hook(t)
eessi_openmpi_load_hook(t)
end


hook.register("load", eessi_load_hook)
"""

def error(msg):
Expand Down