Explicitly set $EESSI_CPU_FAMILY in CI that checks missing installations#433
Merged
ocaisa merged 2 commits intoEESSI:2023.06-software.eessi.iofrom Dec 19, 2023
Merged
Conversation
|
Instance
|
Member
|
I was just about to make the same PR. Shouldn't you also do it in the second instance below this line (line 58)? I know it has no practical consequence but since you know it's a potential issue, might as well keep it consistent |
Collaborator
Author
Ah, thanks, overlooked that one. May not be strictly necessary (as it only checks GCC), but I've added it anyway. |
ocaisa
approved these changes
Dec 19, 2023
boegel
added
2023.06-software.eessi.io
TopRichard
added a commit
to TopRichard/software-layer
that referenced
this pull request
Jul 23, 2024
…ealpath2 Use readlink -f instead of realpath (CentOS6)2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets/overrides
$EESSI_CPU_FAMILYto the part before the first slash of$EESSI_SOFTWARE_SUBDIR_OVERRIDE, as it's otherwise always set to the architecture of the runner (i.e.x86_64). This causes issues with checks in our EB configuration that use$EESSI_CPU_FAMILY, e.g. for filtering dependencies foraarch64CPUs, which in turn cause the CI to fail for these architectures. This just happened in #432 .