move utils.sh to scripts/utils.sh + also update script to create tarballs to also cover scripts/ dir#213
Conversation
bedroge
left a comment
bedroge
left a comment
There was a problem hiding this comment.
Looks good to me too, we can also merge EESSI/filesystem-layer#139 after this PR has been merged.
|
@huebner-m Why did no CI run on this PR? This should have triggered something (tarballing the init/scripts is pretty easy and indirectly checks utils.sh) |
That's because @huebner-m hasn't contributed to this repo yet, then CI doesn't run (that's done to avoid leaking secrets like tokens to "contributors" with malicious intent). |
|
The |
… into move_bash_utils
| - utils.sh | ||
| - scripts/utils.sh | ||
| - update_lmod_cache.sh | ||
| - create_directory_tarballs.sh |
There was a problem hiding this comment.
This only makes sure that this workflow is triggered when changes are made to create_directory_tarballs.sh - we're not actually testing create_directory_tarballs.sh directly in this workflow... Could/should we?
There was a problem hiding this comment.
The test should work now (it did locally). However, the CI will still fail until this PR is merged because the script downloads a tarball of the main branch to build the final tarballs and the new subdirectory doesn't exist there yet.
boegel
changed the title
….6-gompi-foss/2022a
{2023.06}[foss/2022a] CDO v2.0.6
…to nessi-23.06-add-R-2022a fix merge conflict after EESSI#213
4 participants
This is a suggestion for a new directory to be shipped with EESSI. We could use this directory to ship the scripts needed to add NVIDIA GPU support, see e.g. #212