flesh out script to update Lmod cache#168
Merged
ocaisa merged 4 commits intoEESSI:mainfrom Jun 1, 2022
Merged
Conversation
ocaisa
approved these changes
Jun 1, 2022
Member
ocaisa
left a comment
ocaisa
left a comment
There was a problem hiding this comment.
I like this, makes it easy to entertain the idea of including different MNSes in the cache and utils.sh is also a welcome addition
ocaisa
requested changes
Jun 1, 2022
update_lmod_cache.sh
Outdated
| # Script to update Lmod cache in EESSI | ||
| # | ||
|
|
||
| source utils.sh |
Member
There was a problem hiding this comment.
Probably need to ensure we can pick this up from the same directory as the script (so use $TOPDIR)
EESSI-pilot-install-software.sh
Outdated
| check_exit_code $? "Lmod cache updated" "Lmod cache update failed!" | ||
|
|
||
| ls -lrt ${EASYBUILD_INSTALLPATH}/.lmod/cache | ||
| ./update_lmod_cache.sh ${EPREFIX} ${EASYBUILD_INSTALLPATH} |
Member
There was a problem hiding this comment.
Careful with the use of ./, use $TOPDIR
EESSI-pilot-install-software.sh
Outdated
| fatal_error "${fail_msg}" | ||
| fi | ||
| } | ||
| source utils.sh |
Member
There was a problem hiding this comment.
Probably need to ensure we can pick this up from the same directory as the script (so use $TOPDIR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes things a bit more modular.
I used the
update_lmod_cache.shscript to create the tarballs to fix #165